<div class="gmail_quote">2011/5/9 Aaron J. Seigo <span dir="ltr"><<a href="mailto:aseigo@kde.org">aseigo@kde.org</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On Saturday, May 7, 2011 14:13:04 Martin Klapetek wrote:<br>
> > in any case, the fix would be pretty simple. the code is in kde-<br>
> > runtime/knotify/notifybypopup.cpp .. at a quick glance it looks like<br>
> > simply checking for an icon on the KNotifyConfig* that is handed in to<br>
> > the notify method would suffice. perhaps this could even be done in the<br>
> > getAppCaptionAndIconName method.<br>
><br>
> Great, I'll have a look. Would this patch be accepted for 4.7 or is it<br>
> already too late?<br>
<br>
</div>probably too late for the 4.7 schedule, but we can put into git at least where<br>
it will be ready for merging. if it was a smaller feature set i might suggest<br>
we try and cheat a bit since we aren't at hard freeze yet, but it's a fairly<br>
significant change that will affect public api in kdelibs, knotify and<br>
eventually a key plasmoid :)<br></blockquote><div><br></div><div>Ok, I think we can live with this for a while. I'll work on this later this week and then I'll post a patch to reviewboard. Is that ok with you?</div>
<div><br></div><div>--Marty</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<font color="#888888"><br>
--<br>
</font><div><div></div><div class="h5">Aaron J. Seigo<br>
humru othro a kohnu se<br>
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43<br>
<br>
KDE core developer sponsored by Qt Development Frameworks<br>
</div></div><br>_______________________________________________<br>
KDE-Telepathy mailing list<br>
<a href="mailto:KDE-Telepathy@kde.org">KDE-Telepathy@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kde-telepathy" target="_blank">https://mail.kde.org/mailman/listinfo/kde-telepathy</a><br>
<br></blockquote></div><br>