<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101284/">http://git.reviewboard.kde.org/r/101284/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 3f1dd3b94ab2b56abb43a51b7b78a9cd162325d0 by Aaron Seigo.</pre>
<br />
<p>- Commit</p>
<br />
<p>On May 6th, 2011, 7:45 p.m., Luc Menut wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Luc Menut.</div>
<p style="color: grey;"><i>Updated May 6, 2011, 7:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since last commit to fix bug 262614,
http://commits.kde.org/kde-workspace/abcd170758a32efd8b082bacb5918ee4a6ac05ea in KDE/4.6
http://commits.kde.org/kde-workspace/bedb02e9887ecd9ca429a88e680cc3f138bf2f50 in master
the applications are now launched two times, because the signal is connected two times:
38 connect(m_menu, SIGNAL(triggered(QAction*)), this, SLOT(switchTo(QAction*)));
39 connect(m_menu, SIGNAL(triggered(QAction*)), this, SLOT(switchTo(QAction*)));
removing one of the lines fixes this.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tested on KDE 4.6.2.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=262614">262614</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/containmentactions/applauncher/launch.cpp <span style="color: grey">(cbc7175)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101284/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>