<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101302/">http://git.reviewboard.kde.org/r/101302/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 6th, 2011, 7:28 a.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this is the wrong fix. well, it's not really a fix at all, it just allows any broken thing to go through. removing error checking is rarely the answer ;) clearly, it is failing for single image file wallpapers, which means Package::isValid() is thinking the package is missing things.
if you apply this simple patch in kdelibs/plasma, does it fix things for you:
diff --git a/plasma/private/packages.cpp b/plasma/private/packages.cpp
index 5e064d9..f24a283 100644
--- a/plasma/private/packages.cpp
+++ b/plasma/private/packages.cpp
@@ -266,6 +266,7 @@ void WallpaperPackage::pathChanged()
findBestPaper();
} else {
// dirty trick to support having a file passed in instead of a directory
+ removeDefinition("images");
addFileDefinition("preferred", info.fileName(), i18n("Recommended wallpaper file"));
setContentsPrefixPaths(QStringList());
//kDebug() << "changing" << path() << "to" << info.path();
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ok, i just committed a slightly better fix than the above path to master to kdelibs/plasma/private/packages.cp. can you check if that works for you and if so i'll backport it.</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On May 6th, 2011, 5:17 a.m., Raphael Kubo da Costa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Raphael Kubo da Costa.</div>
<p style="color: grey;"><i>Updated May 6, 2011, 5:17 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do not check if the created Plasma::Package is valid.
Wallpapers consisting of a single image (without a .desktop metadata or anything else), usually obtained via GHNS, are not valid packages, but are valid wallpapers.
Commit b60136e, besides moving the loading code to a separate thread, also started checking if a given found path was also a valid package, which kept any wallpaper downloaded via the "get new wallpapers" button from being listed at all.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All downloaded wallpapers are listed and selectable again.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=269587">269587</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/wallpapers/image/backgroundlistmodel.cpp <span style="color: grey">(3c92024)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101302/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>