<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101235/">http://git.reviewboard.kde.org/r/101235/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 26th, 2011, 4:14 p.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">took a quick look through it and didn't see anything that popped out as "wrong"; seems to work as well.
the config UI and dialogs for this plasmoid needs some serious work though :/</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah, I think about only supporting tabs --> hiding them in fact if there is just one.
This alone would make the ui a little easier, as well as removing the option to hide the tabs.
Btw. do you know what I have to do that the plasma job tracker displays an error message for a specific job? Or would I have to display a seperate message via a KNotification::event?</pre>
<br />
<p>- Matthias</p>
<br />
<p>On April 26th, 2011, 9:47 a.m., Matthias Fuchs wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Matthias Fuchs.</div>
<p style="color: grey;"><i>Updated April 26, 2011, 9:47 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds possiblity to create a Comic Book Archive (.cbz) for a range: All, BeginTo, EndTo, Range
The job is displayed using the global job tracker, though atm. I have not implemented the total number of files that have to be downloaded, since that is more complicated. I might do that later.
There is one thing I don't understand. How do I set an error that the job tracker ui will also display it? The way I am setting the error apparntly did not result in the plasma job ui tracker to display it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/comic/CMakeLists.txt <span style="color: grey">(8513d9c)</span></li>
<li>applets/comic/comic.h <span style="color: grey">(7134c72)</span></li>
<li>applets/comic/comic.cpp <span style="color: grey">(88a2e31)</span></li>
<li>applets/comic/comicarchivedialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/comic/comicarchivedialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/comic/comicarchivedialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/comic/comicarchivejob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/comic/comicarchivejob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>dataengines/comic/comicprovider.cpp <span style="color: grey">(73f1791)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101235/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>