<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100846/">http://git.reviewboard.kde.org/r/100846/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Elvis Stansvik.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hey guys. My first patch for plasma, so might be a bit rough. Suggestions welcome.
Hardware temperature sensors are often off by +/- a degrees from the actual temperature. This patch lets the user configure a constant offset for each temperature reading to compensate for this.
See attached screenshot.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- The temperatures in the visualization are correctly offset by the configured offsets.
- The offsets are correctly saved to plasma-desktop-appletsrc.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/system-monitor/CMakeLists.txt <span style="color: grey">(b160c2f1ffaf2b02df688c9e736599cde98e21d3)</span></li>
<li>plasma/generic/applets/system-monitor/temperature-offset-delegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/system-monitor/temperature-offset-delegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/system-monitor/temperature.h <span style="color: grey">(049a80f9394b05b3f121a58fa200f99ce61f5ea0)</span></li>
<li>plasma/generic/applets/system-monitor/temperature.cpp <span style="color: grey">(16f06aa04c16eb1595cdbc79138c7ed0519c47dc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100846/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100846/s/97/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/03/12/temperature-offset_400x100.png" style="border: 1px black solid;" alt="The UI for changing temperature offsets." /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>