<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100799/">http://git.reviewboard.kde.org/r/100799/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 5th, 2011, 9:22 a.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">nice fix; i have a feeling this code could be simplified somewhat, but let's cover all the corner cases first.
the issue you note about setting the size in a larger resolution and then switching back to a smaller one is an interesting one indeed. the goal was (and i stress _was_, as we can alter this :) to allow per-resolution panel settings. but as you note, that may not indeed be what is wanted/expected all the time.
for now, in terms of fixing this stuff up for 4.6.2, i don't think we need to address it. but for 4.7 it might be nice to lay down some arbitrary "rules" for panel sizing between resolution changes that keeps some flexibility and obeys "least surprise" as much as possible and (re-?)write this code to match those rules.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks. Pushed to master. Umm, is there something else I need to do in order for this to appear in 4.6.2?</pre>
<br />
<p>- Yuen Hoe</p>
<br />
<p>On March 5th, 2011, 9:06 a.m., Yuen Hoe Lim wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Yuen Hoe Lim.</div>
<p style="color: grey;"><i>Updated March 5, 2011, 9:06 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This should fix one of the reported problems in bug 209962. It prevents parts of the panel from going off-screen when the screen resolution is reduced by reducing the offset (if the panel can fit and is just not positioned to) or by reducing the panel size if the panel is larger than the screen. I'm just basically following what the "pinching strategy" comment written there in the source file says, since it seems to have not been implemented.
I also noted while working on this that the panel saves its sizes to config when the screen size changes, and later _always_ restores this setting whenever the screen size is reverted. This creates the following somewhat unintuitive possibility:
- at resolution 1 I maximize the panel
- I change the screen to resolution 2 that is not too much larger or smaller than resolution 1
- at resolution 2 I make the panel very small, say 20% of the screen width
- now I switch back to resolution 1
- the panel becomes maximized again (because the maximized size is saved and associated with resolution 1)
Is this intended behavior? Or should that be fixed in some way too?
(first git patch btw, hope I didn't do anything wrong..)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Basic testing on trunk, seems to work. Notably despite what is written in the bug page, this issue affects non-multi-screen setups as well. It's a change-in-resolution issue.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=209962">209962</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/shell/panelview.cpp <span style="color: grey">(ee5abca)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100799/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>