<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100750/">http://git.reviewboard.kde.org/r/100750/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 4th, 2011, 4:02 p.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">nice idea :)
there is a string translation (localization) issue on lines 615-617 and a handful of whitespace issues. once those are addressed, please commit.</pre>
</blockquote>
<p>On March 4th, 2011, 6:59 p.m., <b>J Janz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* On strings, some thoughts:
- For the options, "No title" or, maybe better, just "None" is more explicit about what's going to happen than "Empty" (you'll end up with no title and not an empty space) and, possibly, "title" is redundant in "Default title" option (you're setting the title, so "Default" should do it); and
- Maybe there's no more point on keeping the "Custom" in the label (I suggest dropping it and leaving it just as "Title", since you're actually setting the options for the title rather than just customizing its text).
* On the (agreed, great) idea for the widget, if it's an editable combobox (that is, if the options don't come up only if the user types something, less discoverable) the user can, instead of exclusively typing, always just open the drop-down-list of options and choose one of the three or, then, type anything he wants in place.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree J! Thanks for your nice opinions :)
I think that the current completion box is a little bit ugly, IMHO It's better to create a custom widget for this rather than using KLineEdit with completionbox (maybe inherit from QComboBox?).
Aaron, Sebastian, please let me know if you think this is OK so that I start implementing the widget! ;)
Thanks</pre>
<br />
<p>- Farhad</p>
<br />
<p>On March 3rd, 2011, 1:39 p.m., Farhad Hedayati Fard wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Farhad Hedayati Fard.</div>
<p style="color: grey;"><i>Updated March 3, 2011, 1:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Let the user set a blank label. The label should not take up any space when it is blank.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works fine here! </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/applets/folderview/folderview.h <span style="color: grey">(2241b12)</span></li>
<li>plasma/applets/folderview/folderview.cpp <span style="color: grey">(f604277)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100750/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100750/s/84/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/02/26/folderview_settings_400x100.png" style="border: 1px black solid;" alt="folderview configuration dialog" /></a>
<a href="http://git.reviewboard.kde.org/r/100750/s/85/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/02/26/folderview_400x100.png" style="border: 1px black solid;" alt="folderview with blank label" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>