<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100523/">http://git.reviewboard.kde.org/r/100523/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is in a file copied in from Akonadi and I would strongly prefer us not to patch them up in plasma. I intend to occasionally update the code from Akonadi until such time as the required classes become public and we can delete the copy, so would prefer not to have keep track of additional patches to be applied. Please try fix this in Akonadi itself and we can then copy it over intact.</pre>
<br />
<p>- John</p>
<br />
<p>On February 2nd, 2011, 8:19 a.m., Mario Bensi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDEPIM and Plasma.</div>
<div>By Mario Bensi.</div>
<p style="color: grey;"><i>Updated Feb. 2, 2011, 8:19 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually, there is an assert when the collection id are not the same you
are store in your cache. I work on Zanshin and I can move an Item from a
Collection to another and i can reproduce the same behaviour with akonadiconsole.
This path remove the assert on this case and avoid a crash when we move
the item to a different collection.
I add kdepim in groups because a part of the code comes from kdepim/akonadi/kcal</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/dataengines/calendar/akonadi/calendar.cpp <span style="color: grey">(71e4fe6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100523/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>