<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100557/">http://git.reviewboard.kde.org/r/100557/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks good; i do think we should centralize this kind of thing, however, so we can change it if need be in just one place.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100557/diff/1/?file=8390#file8390line56" style="color: black; font-weight: bold; text-decoration: underline;">kcontrol/keyboard/keyboard_applet.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KeyboardApplet::KeyboardApplet(QObject *parent, const QVariantList &args):</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">56</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_svg</span> <span class="o">=</span> <span class="k">new</span> <span class="n">Plasma</span><span class="o">::</span><span class="n">Svg</span><span class="p">(</span><span class="k">this</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ws</pre>
</div>
<br />
<p>- Aaron J.</p>
<br />
<p>On February 4th, 2011, 2:10 p.m., Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Feb. 4, 2011, 2:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">a sore point in the styling right now is the text in the systray area, so the keyboard layout indicator and the clock looking a bit out of place compared to the systray icon styling.
now, if we exclude doing an entire font in svg (and i really don't wan that ;) we can come to some approximations:
it uses a svg similar to the texture of the systray icons as text background, and a very light blur that looks more like an outline.
a theme can quite costumize it by changing the widgets/textbackground svg.
still to do, making the shadow more configurable in color and position.
This could go in Plasma::PaintUtils, but i would rather duplicate it here and in the clock for now, to avoid it being abused too easily (can get ugly and is a bit expensive to generate)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/keyboard/keyboard_applet.h <span style="color: grey">(2fb9c98fde72f48a20dd853477e620a4da61aa1a)</span></li>
<li>kcontrol/keyboard/keyboard_applet.cpp <span style="color: grey">(2b63ce78bfa6d6fbde27a66dc42d7578b12b075b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100557/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100557/s/68/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/02/04/keyb1_400x100.png" style="border: 1px black solid;" alt="" /></a>
<a href="http://git.reviewboard.kde.org/r/100557/s/69/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/02/04/keyb2_400x100.png" style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>