<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6108/">http://svn.reviewboard.kde.org/r/6108/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A few remarks after a quick look:
- you should not leave the debug output, too much noise for reading the diff, please remove and repost new diff
- you should not modify indentation - > correct in new diff
- the Phonon headers do not need to be included twice
- where is the pig.wav from? It should be installed and read from global installation with KStandardDirs. And the name should be changed!</pre>
<br />
<p>- Anne-Marie</p>
<br />
<p>On December 12th, 2010, 7:20 p.m., Sunny Sharma wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Aaron Seigo and Anne-Marie Mahfouf.</div>
<div>By Sunny Sharma.</div>
<p style="color: grey;"><i>Updated 2010-12-12 19:20:12</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hello Everybody,
i have implemented the chiming of the analog clock every hour.though i have hard coded it and it would only chime every hour. and not for 45 mins. Presently I am working on the development of a ui which would allow the user to set the clock to chime according to the choice of the user.
thanks,
sunny_slls</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=232004">https://bugs.kde.org/show_bug.cgi?id=232004</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/CMakeLists.txt <span style="color: grey">(1203585)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.h <span style="color: grey">(1203585)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp <span style="color: grey">(1203585)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6108/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>