<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6042/">http://svn.reviewboard.kde.org/r/6042/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Aaron Seigo.</div>
<div>By Matthias Fuchs.</div>
<p style="color: grey;"><i>Updated 2010-12-04 14:24:09.010483</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds modifications to fix another bug.
The fixes would be commited seperately though are combined here for an easier review-process.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Allows a wider range of urls without a protocol to be accepted, like those containing umlauts etc., queries, or IPV4-Adresses.
If no protocol has be defined, then ports aren't supported.
BUG:227380
Correctly handle protocols that are not a NetorkLocation or http, ftp.
BUG:228017</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">====More Urls:====
Tried with different urls, including the one of the bug report www.hörstreich.de, google.at, 74.125.39.99/search?hl=en&biw=1280&bih=891&q=kde&aq=f&aqi=g10&aql=&oq=&gs_rfai= etc.
Problem:
There is one problem though that is unrelated to this patch and did _not_ exist in KDE 4.5.4
If I enter "google.at" it will display the result that I can go to http://google.at, yet if I add ":\d" e.g. google.at:8 the result won't be updated as nothing matches, yet the old result still stays.
In KDE 4.5.4 the old result would also disappear after a short time.
====Correctly handle Protocls:====
Tried mailto:chris@example.com, mailto:infobot@example.com?subject=current-issue and ~/kde.
Problem:
Again this problem existed before this patch.
In BUG:167862 there is mentioned, that simply entering a folder name in your $HOME-dir displays the folder, so instead of "~/kde" also "kde" should work. Though this is not the case. Instead when the "Nepomuk Desktop Search Runner" is activated just inputing "kde" works, unless it is excluded from indexing.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=227380">227380</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=228017">228017</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/plasma/generic/runners/locations/locationrunner.cpp <span style="color: grey">(1203489)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6042/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>