<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6032/">http://svn.reviewboard.kde.org/r/6032/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the mechanism for storing these preferences is so amazingly ugly :/ i've wanted default-apps-stored-in-mimetype-db for going on 6 years now, and this is a great example of why. *sigh* anyways looks ok ...</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/6032/diff/1/?file=42068#file42068line452" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmarksrunner.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void BookmarksRunner::matchFirefoxBookmarks(Plasma::RunnerContext& context, bool allBookmarks, const QString& term)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">452</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">service</span><span class="p">.</span><span class="n">isNull</span><span class="p">())</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"if (service)" is clearer?</pre>
</div>
<br />
<p>- Aaron</p>
<br />
<p>On December 2nd, 2010, 7:20 p.m., Matthias Fuchs wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Aaron Seigo.</div>
<div>By Matthias Fuchs.</div>
<p style="color: grey;"><i>Updated 2010-12-02 19:20:32</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If no specific browser has been set as default, uses the application that is set to open html-files.
Ideally there would be a method in kdelibs to retrieve the default browser though I suppose that is a different task than this bug.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=224406">224406</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/apps/dolphin/src/tests/dolphinviewtest_allviewmodes.cpp <span style="color: grey">(1202673)</span></li>
<li>/trunk/KDE/kdebase/apps/dolphin/src/tests/testbase.cpp <span style="color: grey">(1202673)</span></li>
<li>/trunk/KDE/kdebase/runtime/nepomuk/services/backupsync/gui/nepomukbackup.desktop <span style="color: grey">(1202673)</span></li>
<li>/trunk/KDE/kdebase/runtime/plasma/containments/newspaper/appletoverlay.cpp <span style="color: grey">(1202673)</span></li>
<li>/trunk/KDE/kdebase/runtime/plasma/containments/newspaper/appletsview.cpp <span style="color: grey">(1202673)</span></li>
<li>/trunk/KDE/kdebase/runtime/plasma/declarativeimports/core/theme.cpp <span style="color: grey">(1202673)</span></li>
<li>/trunk/KDE/kdebase/runtime/plasma/declarativeimports/core/theme_p.h <span style="color: grey">(1202673)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/shell/activitymanager/filterbar.cpp <span style="color: grey">(1202673)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/containmentactions/switchactivity/switch.cpp <span style="color: grey">(1202673)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/containmentactions/switchwindow/switch.cpp <span style="color: grey">(1202673)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/activities/activities.operations <span style="color: grey">(1202673)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/activities/activityengine.cpp <span style="color: grey">(1202673)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/activities/activityjob.cpp <span style="color: grey">(1202673)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmarksrunner.cpp <span style="color: grey">(1202673)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6032/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>