<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6005/">http://svn.reviewboard.kde.org/r/6005/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 30th, 2010, 1:04 a.m., <b>Davide Bettio</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should we apply this patch while waiting someone who fix this bug in Qt?</pre>
</blockquote>
<p>On November 30th, 2010, 1:31 a.m., <b>Aaron Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">sure (if only because the bug has been closed as "out of scope"), but annotate the code with a comment explaining the situation and a link to the bug report on the qt bug tracker.</pre>
</blockquote>
<p>On November 30th, 2010, 10:06 a.m., <b>Stephen Kelly</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just for clarity, I think it's similar to the bug I filed with Qt before, but maybe not the same.
I think you should file a new Qt bug and link to that.</pre>
</blockquote>
<p>On November 30th, 2010, 12:14 p.m., <b>Anne-Marie Mahfouf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Stephen did you investigate further? I can't reproduce on a test case i.e. if I have an empty QTextEdit and set bold then the first char is bold. Same if I use the example TextEdit and click NEw and set Bold then the first char is bold.
Is there a reason why you point to Qt and can you explain it so I can make a test case? </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nope I didn't investigate further yet. I pointed to Qt because of of previous bugs, and because of something similar a kopete developer asked me about QTextDocument before.
If you can't create a test case I may be wrong. Do we have a KRichTextEdit based test case?
I'm currently rebuilding my development environment, so I probably won't have a chance until tomorrow. </pre>
<br />
<p>- Stephen</p>
<br />
<p>On November 28th, 2010, 8:23 p.m., Davide Bettio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Stephen Kelly.</div>
<div>By Davide Bettio.</div>
<p style="color: grey;"><i>Updated 2010-11-28 20:23:45</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Text format of the note can't be changed while the note is empty, so I add a space and I change the text format.
This work around is rather stupid but I don't have any nicer idea.
Anyway this might be a bug in KRichTextEdit so I add to this review request also steveire.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdeplasma-addons/applets/notes/notes.h <span style="color: grey">(1201054)</span></li>
<li>trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp <span style="color: grey">(1201054)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6005/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>