<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6006/">http://svn.reviewboard.kde.org/r/6006/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Step 3 probably needs changes in slidingpopups effect.
When the window is added it is added to an internal hash. The effect does not remove the window from the hash when the property is changed. So here we could add an explicit remove by setting the property to e.g. 0 and check that.
If you want to have a look on it: trunk/KDE/kdebase/workspace/kwin/effects/slidingpopups/slidingpopups.cpp method propertyNotify. You can find examples for how to explicitly disable in taskbarthumbnails or highlightwindow effects.</pre>
<br />
<p>- Martin</p>
<br />
<p>On November 28th, 2010, 8:44 p.m., Matthias Fuchs wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Matthias Fuchs.</div>
<p style="color: grey;"><i>Updated 2010-11-28 20:44:27</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Turns the slide effect off if floating is used. This is related to BUG:218678 but does not completely fix it.
Steps to reproduce:
1. set krunner to top screen, hide/show it
2. set krunner to floating
3. hide it
4. show it
Step 3 and 4 use the slide-animation that should only be used if it is at the top.
This patch fixes this behavior to some degree.
Now only step three will use the slide animation and from that point on the correct one will be used.
I am not sure how I can also fix step 3, help welcome! :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/krunner/krunnerdialog.cpp <span style="color: grey">(1201754)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6006/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>