<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6007/">http://svn.reviewboard.kde.org/r/6007/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i think the real problem is in KSysGuardProcessList::loadSettings(const KConfigGroup &cg) where it uses hard coded defaults such as this line:
setUnits((ProcessModel::Units) cg.readEntry("units", (int)ProcessModel::UnitsKB));
it should be possible to do:
m_processList.setUnits(ProcessModel::UnitsMB);
m_processList.loadSettings(config);
and have the current settings used as the defaults. the hardcoded defaults can be set up in the ctor of KSysGuardProcessList. so the setUnits line above would become:
setUnits((ProcessModel::Units) cg.readEntry("units", (int)d->m_model.units()));
thoughts?</pre>
<br />
<p>- Aaron</p>
<br />
<p>On November 28th, 2010, 11:31 p.m., Matthias Fuchs wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Aaron Seigo and John Tapsell.</div>
<div>By Matthias Fuchs.</div>
<p style="color: grey;"><i>Updated 2010-11-28 23:31:11</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The KSystemActivityDialog uses MB as default unit.
BUG:222022</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=222022">222022</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/krunner/ksystemactivitydialog.cpp <span style="color: grey">(1201754)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6007/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>