<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5849/">http://svn.reviewboard.kde.org/r/5849/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 15th, 2010, 1:05 p.m., <b>Aaron Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">is there a need for the underscore, or for being able to configure it? would it be enough to just check if there is more than one word after "spell", check if that's a valid dictionary and if so use it? that would lead to imho the more natural grammar of "spell hello", "spell en hello", "spell de Kraul".
being able to write "spell german Kraul" would be really nice (prevents the user from having to know the language codes) but perhaps asking too much from the runner :)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In general there is no need to specify the underscore, the only reason I did this is in the case that underscores aren't present on the users' keyboard.
But as you suggest just using a space would be better and also simplify the code.
On the other suggestion, yeah I thought about that. Though I am not sure if all language-names are translated to all languages, i.e. if you have to enter "German" or "deutsch". Because imo it would be most comfortable to enter the language-name in the set locale.</pre>
<br />
<p>- Matthias</p>
<br />
<p>On November 15th, 2010, 12:45 p.m., Matthias Fuchs wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Ryan Bitanga.</div>
<div>By Matthias Fuchs.</div>
<p style="color: grey;"><i>Updated 2010-11-15 12:45:41</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Feature for 4.7
As the summary says, this patch allows to define which dictionary the spell check runner should use. "spell" will always use the default one.
"spell_de" or more specifically "spell_de_DE" would work now.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeplasma-addons/runners/spellchecker/spellcheck.h <span style="color: grey">(1197278)</span></li>
<li>/trunk/KDE/kdeplasma-addons/runners/spellchecker/spellcheck.cpp <span style="color: grey">(1197278)</span></li>
<li>/trunk/KDE/kdeplasma-addons/runners/spellchecker/spellcheck_config.h <span style="color: grey">(1197278)</span></li>
<li>/trunk/KDE/kdeplasma-addons/runners/spellchecker/spellcheck_config.cpp <span style="color: grey">(1197278)</span></li>
<li>/trunk/KDE/kdeplasma-addons/runners/spellchecker/spellcheck_config.ui <span style="color: grey">(1197278)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5849/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>