<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5846/">http://svn.reviewboard.kde.org/r/5846/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should I backport this one including with http://reviewboard.kde.org/r/5844/?</pre>
<br />
<p>- Matthias</p>
<br />
<p>On November 14th, 2010, 11:30 a.m., Matthias Fuchs wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Aaron Seigo.</div>
<div>By Matthias Fuchs.</div>
<p style="color: grey;"><i>Updated 2010-11-14 11:30:18</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KRunner's width can be resized when it is floating.
Also resizing on the left size is improved --> the cursor stays at the left edge.
BUG:256334
What is still not ideal is when you resize the runner on the left side and it reaches the right screenboarder, then it looks a little choppy but works.
There is also still a problem existing -- unrelated to this patch: When it is on top and in the middle and you resize it to the maximum, hide it, try to move it ... it sometimes happens that you can't resize it anymore.
Note: This review also includes http://reviewboard.kde.org/r/5844/ as I was not able to do it without via post-review.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tried different cases both in floating and non-floating:
resizing it both on the left and right when it is centered, positioned on the left or on the right</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/krunner/krunnerdialog.h <span style="color: grey">(1196906)</span></li>
<li>/trunk/KDE/kdebase/workspace/krunner/krunnerdialog.cpp <span style="color: grey">(1196906)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5846/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>