<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5765/">http://svn.reviewboard.kde.org/r/5765/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i don't see why this patch removes the ability to have multiple paths per entry, since both approaches are useful though perhaps in different situations. the only downside i see to keeping searchPaths for entries is that we don't have an immediate use case for them, which makes it a slightly speculative feature if it isn't used here. i can imagine various situations where it would make sense, however.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/5765/diff/1/?file=40613#file40613line167" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdelibs/plasma/package.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Package &Package::operator=(const Package &rhs)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">167</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">foreach</span> <span class="p">(</span><span class="k">const</span> <span class="n">QString</span> <span class="o">&</span><span class="n">path</span><span class="p">,</span> <span class="n">d</span><span class="o">-></span><span class="n">structure</span><span class="o">-></span><span class="n">searchPath</span><span class="p">(</span><span class="n">dir</span><span class="p">))</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">167</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">QFile</span><span class="o">::</span><span class="n">exists</span><span class="p">(</span><span class="n">d</span><span class="o">-></span><span class="n">structure</span><span class="o">-></span><span class="n">path</span><span class="p">()</span> <span class="o">+</span> <span class="n">d</span><span class="o">-></span><span class="n">structure</span><span class="o">-></span><span class="n">contentsPrefixPaths</span><span class="p">().</span><span class="n">last</span><span class="p">()</span> <span class="o">+</span> <span class="n">d</span><span class="o">-></span><span class="n">structure</span><span class="o">-></span><span class="n">path</span><span class="p">(</span><span class="n">dir</span><span class="p">)))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i don't think this will work: if it truly is fallback based, then it should be just fine to have a required item in any of the context prefixes.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/5765/diff/1/?file=40613#file40613line183" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdelibs/plasma/package.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Package &Package::operator=(const Package &rhs)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">183</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">foreach</span> <span class="p">(</span><span class="k">const</span> <span class="n">QString</span> <span class="o">&</span><span class="n">path</span><span class="p">,</span> <span class="n">d</span><span class="o">-></span><span class="n">structure</span><span class="o">-></span><span class="n">searchPath</span><span class="p">(</span><span class="n">file</span><span class="p">))</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">176</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">QFile</span><span class="o">::</span><span class="n">exists</span><span class="p">(</span><span class="n">d</span><span class="o">-></span><span class="n">structure</span><span class="o">-></span><span class="n">path</span><span class="p">()</span> <span class="o">+</span> <span class="n">d</span><span class="o">-></span><span class="n">structure</span><span class="o">-></span><span class="n">contentsPrefixPaths</span><span class="p">().</span><span class="n">last</span><span class="p">()</span> <span class="o">+</span> <span class="n">d</span><span class="o">-></span><span class="n">structure</span><span class="o">-></span><span class="n">path</span><span class="p">(</span><span class="n">file</span><span class="p">)))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">same as above</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/5765/diff/1/?file=40613#file40613line219" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdelibs/plasma/package.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString Package::filePath(const char *fileType, const QString &filename) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">219</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">206</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">foreach</span> <span class="p">(</span><span class="n">QString</span> <span class="n">prefix</span><span class="p">,</span> <span class="n">d</span><span class="o">-></span><span class="n">structure</span><span class="o">-></span><span class="n">contentsPrefixPaths</span><span class="p">())</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the implicit assumption here is that fallbacks are listed first. that's probably fair, but should be noted in the apidox for PackageStructure. same situation with my patch, so not your oversight alone :)</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/5765/diff/1/?file=40613#file40613line364" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdelibs/plasma/package.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString Package::contentsHash() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">362</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">metadataPath</span> <span class="o">=</span> <span class="n">d</span><span class="o">-></span><span class="n">structure</span><span class="o">-></span><span class="n">path</span><span class="p">()</span> <span class="o">+</span> <span class="s">"metadata.desktop"</span><span class="p">;</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">349</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">metadataPath</span> <span class="o">=</span> <span class="n">d</span><span class="o">-></span><span class="n">structure</span><span class="o">-></span><span class="n">path</span><span class="p">()</span> <span class="o">+</span> <span class="s">"metadata.desktop"</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this means that the metadata file will be added to the hash for each contents prefix, which is incorrect. that should be moved out of the foreach loop</pre>
</div>
<br />
<p>- Aaron</p>
<br />
<p>On November 4th, 2010, 2:44 p.m., Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Aaron Seigo.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated 2010-11-04 14:44:46</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">in relation to http://svn.reviewboard.kde.org/r/5763/
i still can't really wrap my mind on that approach, i still see it workig more like this:
- the list of fallbacks is defined on the prefix
- diffrent platforms would have things in different prefixes, to not have reserved words in the contents/ directory
- another shell can have a packagerc with different prefix paths (before plasma/packageformats/%1rc a plasma-$app/packageformats/%1rc should be looked for)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i am not sure the hash still works :/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/plasma/package.cpp <span style="color: grey">(1193070)</span></li>
<li>/trunk/KDE/kdelibs/plasma/packagestructure.h <span style="color: grey">(1193070)</span></li>
<li>/trunk/KDE/kdelibs/plasma/packagestructure.cpp <span style="color: grey">(1193070)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5765/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>