<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5707/">http://svn.reviewboard.kde.org/r/5707/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Albert Astals Cid.</div>
<div>By Chani Armitage.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this is a basic activities dataengine. no frills to start with, just a source for each activity.
the service allows setting the current activity (other features, like setting an activity's name, can be added later).
it uses KActivityController and friends internally.
I'm not sure if I got the i18n right, though - I can't remember how that works for dataengines.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've updated the ActivityBar plasmoid to use the engine, and it works with no regressions :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/dev/null <span style="color: grey">(PRE-CREATION)</span></li>
<li>/dev/null <span style="color: grey">(PRE-CREATION)</span></li>
<li>/dev/null <span style="color: grey">(PRE-CREATION)</span></li>
<li>/dev/null <span style="color: grey">(PRE-CREATION)</span></li>
<li>/dev/null <span style="color: grey">(PRE-CREATION)</span></li>
<li>/dev/null <span style="color: grey">(PRE-CREATION)</span></li>
<li>/dev/null <span style="color: grey">(PRE-CREATION)</span></li>
<li>/dev/null <span style="color: grey">(PRE-CREATION)</span></li>
<li>/dev/null <span style="color: grey">(PRE-CREATION)</span></li>
<li>/dev/null <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/plasma/generic/applets/activitybar/activitybar.h <span style="color: grey">(1188056)</span></li>
<li>trunk/KDE/kdebase/workspace/plasma/generic/applets/activitybar/activitybar.cpp <span style="color: grey">(1188056)</span></li>
<li>trunk/KDE/kdebase/workspace/plasma/generic/dataengines/CMakeLists.txt <span style="color: grey">(1188056)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5707/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>