<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5608/">http://svn.reviewboard.kde.org/r/5608/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Anthony Bryant.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch fixes some usability problems in the fifteen puzzle's config:
* Don't apply the settings before the user presses OK. This was counter-intuitive and broke the cancel button.
* Remove the shuffle button, it doesn't really belong in the config to begin with (I'm working on a patch to add it in the bottom right of the solved puzzle).
* Only update the size of the puzzle if the user actually changed it (this prevents unnecessary resets to the solved view when the user eg. toggles the numerals).
* Use configChanged() and configAccepted() properly.
Also, don't update the pixmaps unless they actually need to be updated, this fixes some inefficiencies (eg. when moving pieces).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested changing between different configurations.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/CMakeLists.txt <span style="color: grey">(1184493)</span></li>
<li>/trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.cpp <span style="color: grey">(1184493)</span></li>
<li>/trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.h <span style="color: grey">(1184493)</span></li>
<li>/trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.cpp <span style="color: grey">(1184493)</span></li>
<li>/trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzleConfig.h <span style="color: grey">(1184493)</span></li>
<li>/trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzleConfig.cpp <span style="color: grey">(1184493)</span></li>
<li>/trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzleConfig.ui <span style="color: grey">(1184493)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5608/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/5608/s/534/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/10/12/fifteen-config_400x100.png" style="border: 1px black solid;" alt="New config dialog" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>