<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5504/">http://svn.reviewboard.kde.org/r/5504/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<p>- Aaron</p>
<br />
<p>On October 1st, 2010, 2 a.m., Christoph Feck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Christoph Feck.</div>
<p style="color: grey;"><i>Updated 2010-10-01 02:00:06</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I used Plasma::PaintUtils::shadowText() to draw a text halo (offset 0,0) around a text.
Unfortunately, that halo got cropped (see the "g").
This patch should
* fix placement of shadow and text inside the resulting pixmap
* fix "addSize" not enlarged for negative offsets
* simplify computation</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/plasma/paintutils.cpp <span style="color: grey">(1181424)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5504/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/5504/s/517/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/10/01/zoom1_400x100" style="border: 1px black solid;" alt="before" /></a>
<a href="http://svn.reviewboard.kde.org/r/5504/s/519/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/10/01/zoom2_1_400x100" style="border: 1px black solid;" alt="after" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>