<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5506/">http://svn.reviewboard.kde.org/r/5506/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looking at how slow kconfig as, this makes storage use sqlite (and makes some methods private, before it's too late)
it can still use some improvements but it's basically working.
two main concerns are:
- is acceptable/safe to link to QtSql and assume the sqlite driver is present?
- i would still see this as a fallback for when an akonadi version is not present (being in another process should slowdown the gui a bit less, but i could not want it in some mobile profiles)
the akonadi version is in the usual status "almost working with developer disappeared" :p</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/plasma/CMakeLists.txt <span style="color: grey">(1179394)</span></li>
<li>/trunk/KDE/kdelibs/plasma/datacontainer.h <span style="color: grey">(1179394)</span></li>
<li>/trunk/KDE/kdelibs/plasma/datacontainer.cpp <span style="color: grey">(1179394)</span></li>
<li>/trunk/KDE/kdelibs/plasma/dataengine.cpp <span style="color: grey">(1179394)</span></li>
<li>/trunk/KDE/kdelibs/plasma/private/datacontainer_p.h <span style="color: grey">(1179394)</span></li>
<li>/trunk/KDE/kdelibs/plasma/private/storage.cpp <span style="color: grey">(1179394)</span></li>
<li>/trunk/KDE/kdelibs/plasma/private/storage_p.h <span style="color: grey">(1179394)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5506/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>