<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5406/">http://svn.reviewboard.kde.org/r/5406/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aaron Seigo.</div>
<p style="color: grey;"><i>Updated 2010-09-22 18:36:20.575729</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This prevents the creation of new pixmaps as much as possible while doing transition effects at the cost of creating more pixmaps on the fly. It introduces a new property, cache, to PixmapTransition to restore the old behaviour. However, most of our widgets already do caching internally, so the added pixmap copy is just that: a copy. It sits around taking up pixmap memory for no particularly good reason. In the Javascript plasmoid I'm working on, it creates a table with buttons, some 146 buttons, in fact. This drops the Pixmap count from nearly 150 for the same (pixel-wise) button pixmap to 1.
Combined with my commits from last night and a new caching scheme for FrameSvg, creating these buttons has dropped from 6-9 seconds on my machine to 2-3 seconds.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">git@coherenttheory.com:plasmoidprogress.git</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/plasma/animations/pixmaptransition.cpp <span style="color: grey">(1178174)</span></li>
<li>/trunk/KDE/kdelibs/plasma/animations/pixmaptransition_p.h <span style="color: grey">(1178174)</span></li>
<li>/trunk/KDE/kdelibs/plasma/paintutils.cpp <span style="color: grey">(1178174)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5406/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>