<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5225/">http://svn.reviewboard.kde.org/r/5225/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 1st, 2010, 4:42 p.m., <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To be honest I do not see the usefulness of such an effect :-)
If I understand your code correctly you are creating four GL Textures for the corners. That are three too many. Mirroring textures is very easy in OpenGL. In general I would prefer if such eyecandy stuff only uses GLSL (which raises the requirements to OpenGL 2). So you would just specify one VBO and use vertex attributes to indicate the corner and do the mirroring in the fragment shader. This would also add the possibility to easily do nice radiant fade outs, so that only the pixel nearest to the corner is black while the other parts are translucent.
It would be nice if you could attach a screenshot and please get feedback from Oxygen (designers) and please add Plasma to the groups as well. This is heavily influencing the look of the Plasma Workspace, so they should also have their say on it.
Oh and please have a look on the HACKING file in kwin source directory for coding style.</pre>
</blockquote>
<p>On September 1st, 2010, 5:12 p.m., <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As far as I understand it, this should not be enabled as default, but only enable eye candy to all those that want emulate Mac designs (and I can already see all the screen shots posted to sites everywhere, where this "effect" is enabled).
Cannot comment on the technical side, but smooth anti-aliasing is a MUST (standard OpenGL anti-aliasing probably is too coarse).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks a lot for reviews and comments.
Can't upload a screenshot in this reviewboard here: [Errno 13] Permission denied: '/var/www/sites/svn.reviewboard.kde.org/htdocs/media/uploaded/images/2010/09/02'
So I added one to this place:
http://img842.imageshack.us/img842/6695/withdarkgreyborder.jpg (with a dark grey frame to simulate a monitor and to get a better impression)
plasma-group is added.
As I can see from http://www.oxygen-icons.org/?page_id=16 Thomas Lübking is already from the Oxygen-Team.
</pre>
<br />
<p>- Christoph</p>
<br />
<p>On September 2nd, 2010, 10:01 a.m., Christoph Fritz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kwin, Plasma and Martin Gräßlin.</div>
<div>By Christoph Fritz.</div>
<p style="color: grey;"><i>Updated 2010-09-02 10:01:55</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Inspired by roundedge http://www.nongnu.org/roundedge/ this kwin effect makes corners of the desktop rounded.
Older Macs and Monitors had this feature too.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/CMakeLists.txt <span style="color: grey">(1170001)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/configs_builtins.cpp <span style="color: grey">(1170001)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5225/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>