<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5035/">http://reviewboard.kde.org/r/5035/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i really dislike such 'magic' features for the reason of trustability. a person will learn patterns of behaviour in the software and expect it to remain within those patterns. whenever the software deviates, the user learns to expect surprises and trust it less. this results in the user being more careful and paying more attention to what they click on, etc. rather than just forgetting about the environment and using it with as little conscious processing as possible. like an experience driver behind the wheel of a car. (which is why the idea of cars that accelerate on their own was so disruptive of an idea even outside of the idea of possible harm and injury.)
unfortunately, we apparently have this feature in the tasks widget already. :/ in fact, it seems to have been part of another commit, probably by accident:
http://websvn.kde.org/?view=revision&revision=997990
that commit message says, "add a configuration ui for adding plasmoids into the systray: only ones marked X-Plasma-NotificationArea=true in their desktop file will show up in the list". it looks like the commit to taskgroup was an accident.
in fact, that it only applies to groups and not to individual windows, that it doesn't check for it being the root group, etc. makes me wonder about the general quality of the feature. those things could be improved in the tasks widget, of course, but personally i don't think this feature actually meets what we're trying to achieve in terms of "magic behaviours are bad".
it's been in there for a year, however, so i'm hesitant to yank it out at this point. and if we leave it in the tasks widget, we should make it consistent with the pager as well.
i'll leave it up to Marco since he was the one who made the original commit to the tasks widget.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5035/diff/1/?file=33993#file33993line892" style="color: black; font-weight: bold; text-decoration: underline;">trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/pager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void Pager::mouseReleaseEvent(QGraphicsSceneMouseEvent *event)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">892</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Plasma</span><span class="o">::</span><span class="n">WindowEffects</span><span class="o">::</span><span class="n">presentWindows</span><span class="p">(</span><span class="n">view</span><span class="p">()</span><span class="o">-></span><span class="n">winId</span><span class="p">(),</span> <span class="n">m_dragStartDesktop</span> <span class="o">+</span> <span class="mi">1</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">view() isn't guaranteed; to be on the (probably overly) safe side, it should be:
QGraphicsView *v = view();
if (v) {
Plasma::WindowEffect::...
}
same below</pre>
</div>
<br />
<p>- Aaron</p>
<br />
<p>On August 28th, 2010, 7:49 a.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Aaron Seigo and Marco Martin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated 2010-08-28 07:49:57</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds support to pager to trigger the present windows effect for the desktop the user clicks on when holding ctrl. This is similar to what we have when clicking on a tasks group when ctrl is hold.
I'm not sure if this is a too hidden feature, but I consider it as could be useful and consistent with the tasks applet.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/pager.cpp <span style="color: grey">(1163977)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5035/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>