<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/5155/">http://reviewboard.kde.org/r/5155/</a>
     </td>
    </tr>
   </table>
   <br />





<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On August 27th, 2010, 3:57 p.m., <b>Marco Martin</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">doesn&#39;t seem to apply correctly</pre>
 </blockquote>







</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it is svn diff that has some problems, it seems. try applying the patch with -p0</pre>
<br />








<p>- Giulio</p>


<br />
<p>On August 26th, 2010, 10:30 a.m., Giulio Camuffo wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Plasma and Aaron Seigo.</div>
<div>By Giulio Camuffo.</div>


<p style="color: grey;"><i>Updated 2010-08-26 10:30:18</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a rewamp of the Applet handle system. Through its modular architecture it easily allows modifications and reuse of code.

It features a base Handle class, AbstractHandle, and a base class for the control elements, ControlElement. I developed an handle based on the actual AppletHandle, DesktopHandle, and the control elements for the usual operations.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It isn&#39;t finished. It&#39;s missing the touch events management (which, however, it&#39;s hard to me to do, &#39;cause i don&#39;t have any touch screen device) and a better drag and drop system between containments. I&#39;d like, however, to know what you think about what i&#39;ve done, especially about the architecture.

What&#39;s here works, though.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/KDE/kdelibs/plasma/CMakeLists.txt <span style="color: grey">(1168271)</span></li>

 <li>trunk/KDE/kdelibs/plasma/applet.h <span style="color: grey">(1168271)</span></li>

 <li>trunk/KDE/kdelibs/plasma/applet.cpp <span style="color: grey">(1168271)</span></li>

 <li>trunk/KDE/kdelibs/plasma/containment.h <span style="color: grey">(1168271)</span></li>

 <li>trunk/KDE/kdelibs/plasma/containment.cpp <span style="color: grey">(1168271)</span></li>

 <li>trunk/KDE/kdelibs/plasma/extenders/extender.cpp <span style="color: grey">(1168271)</span></li>

 <li>trunk/KDE/kdelibs/plasma/extenders/extenderitem.cpp <span style="color: grey">(1168271)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/abstracthandle.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/abstracthandle.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/applet_p.h <span style="color: grey">(1168271)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/applethandle.cpp <span style="color: grey">(1168271)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/applethandle_p.h <span style="color: grey">(1168271)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/configurecontrol.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/configurecontrol.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/containment_p.h <span style="color: grey">(1168271)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/controlelement.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/controlelement.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/controlelement_p.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/desktophandle.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/desktophandle.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/maximizecontrol.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/maximizecontrol.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/movecontrol.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/movecontrol.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/removecontrol.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/removecontrol.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/resizecontrol.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/resizecontrol.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/rotatecontrol.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/rotatecontrol.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/5155/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>