On 24 August 2010 22:06, Aaron J. Seigo <span dir="ltr"><<a href="mailto:aseigo@kde.org">aseigo@kde.org</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
hi ..<br>
<br>
the events runner has been in kdereview for a while now and it is time to<br>
decide what to do with it :)<br>
<br>
Alexey: if there are no known issues with it, please move it into kdeplasma-<br>
addons/runners/<br>
<br>
kdeplasma-addons has no hard restrictions on coding style, but we do encourage<br>
the use of kdelibs style so that there is an ease of switching between plugins<br>
for all plasma developers. it is up to you, however.<br>
<br>
other than that, it would be a very nice feature to do something like: "events<br>
today" or "events tomorrow" and get a list of them back ...<br>
<br>
cheers :)<br>
<br></blockquote><div> </div></div>Interesting, haven't seen that before. A few comments after a quick look, I can get more specific later.<br><br>1) The runner directly interfaces with Akonadi, shouldn't the update parts be moved into a Plasma Service? (Yes, I'm supposed to be looking at moving the Calendar DataEngine into a Service but I'm doing fieldwork right now and won't have time for a few more weeks).<br>
<br>2) It uses Boost shared pointers, shouldn't it be using a Qt equivalent?<br><br>3) The code is a bit messy, it needs some polishing to kdelibs standard.<br><br>4) I don't think variantToDateTime() and dateTimeToVariant() are needed anymore, KDateTime is now a proper QMetaType so will work seamlessly with QVariant.<br>
<br>5) The DateTimeRange and DateTimeParser classes have far more methods in them than actually get used in Event, either trim back to only what is needed, or look to move to kdelibs where it can be used in a general case, but it would need a lot of work, e.g. data members are currently public and accessed directly rather than via get methods.<br>
<br>6) The date/time input formats are not localised, i.e. are not what the user expects to be able to enter. You should try use the standard KLocale read date/time functions, don't try reinvent the wheel. If only a fixed format is possible then ISO format would be preferred using KDateTime methods.<br>
<br>7) Have you tested timezones work properly?<br><br>In short, I don't think it's ready yet. I'd be happy to work with Alexey in a few weeks to use his code to develop a Service for this based around the existing calendar DataEngine.<br>
<br>Cheers!<br><br>John.<br>