<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4947/">http://reviewboard.kde.org/r/4947/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 9th, 2010, 5:48 p.m., <b>Aaron Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">another thought that occurs to me: i wonder if the "translate a package name to an absolute path" doesn't belong in the Desktop Scripting .. that way all wallpapers would get the benefit of it and it would be a penalty paid just once (at initial layout loading).</pre>
</blockquote>
<p>On August 10th, 2010, 11:10 a.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">probably...
fact is however my main use case was for plasma mobile, that doesn't have desktop scripting :/
so probablyboth are needed, this kind of resolution in image, and a convenience function is desktop scripting as well
and what about a static Package *Package::fromName(Qstring)?</pre>
</blockquote>
<p>On August 10th, 2010, 2:27 p.m., <b>Aaron Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"fact is however my main use case was for plasma mobile, that doesn't have desktop scripting"
i suppose the question, then, is: should it.
"this kind of resolution in image"
as long as it can be done without much overhead. it will mean replicating this in every image using wallpaper, though.
"what about a static Package *Package::fromName(Qstring)"
it also needs a package type, since not all packages are installed and queried the same way. and then package structures would need a way to define how to do that lookup; most are currently based on using ksycoca but, as in the case of wallpaper images and themes, they are based on looking at the filesystem. so it's doable, but it's also PackageStructure-dependent.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">>i suppose the question, then, is: should it.
possibly: but then we have again the problem of making the binding a public library or fork it
>as long as it can be done without much overhead. it will mean replicating this in every image using wallpaper
yes, not really good (atm there is just virus as officially distributed?) (weather is using images as well but aren't user configurable in this way)
>as in the case of wallpaper images and themes, they are based on looking at the filesystem
yeah, that's true :/</pre>
<br />
<p>- Marco</p>
<br />
<p>On August 9th, 2010, 3:48 p.m., Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated 2010-08-09 15:48:31</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch makes possible to specify in the config file just the wallpaper name, such as "Ethias" or "Grass"
this would be necessary to do default plasma layouts with a different wallpaper per containment for instance.
the patch looks like a quick and dirty way to me, another could be a Package constructor that takesthe desktop file, or the associated KService as a path..
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp <span style="color: grey">(1157559)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4947/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>