<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4548/">http://reviewboard.kde.org/r/4548/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre>I think it can go in now</pre>
 <br />





<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="/r/4548/diff/2/?file=31028#file31028line811" style="color: black; font-weight: bold; text-decoration: underline;">/dataengine.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"></pre></td>
   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;">void DataEnginePrivate::retrieveStoredData(DataContainer *s)</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">811</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;">    <span class="k">while</span> <span class="p">(</span><span class="o">!</span><span class="n">retrieve</span><span class="o">-&gt;</span><span class="n">error</span><span class="p">())</span> <span class="p">{</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em">this is ok for now but will need to be either of
a) retrieve become asymmetric with store and retrieve everything while store does for a single key value pair
b) not using a service anymore, would be directly kconfig, akonadi or whatever</pre>
</div>
<br />



<p>- Marco</p>


<br />
<p>On July 12th, 2010, 8:10 p.m., Brian Pritchett wrote:</p>




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Brian Pritchett.</div>


<p style="color: grey;"><i>Updated 2010-07-12 20:10:03</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0;">DataEngines can mark or unmark their sources to be cached with void DataEngine::setEnableCache(const QString &amp;source, bool cache). If the DataEngine has implemented their own source by inheriting DataContainer, then DataContainer::setEnableCache(bool cache) will work.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0;">I have tested it with the microblogging dataengine/plasmoid.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdelibs/plasma/CMakeLists.txt <span style="color: grey">(1147556)</span></li>

 <li>/trunk/KDE/kdelibs/plasma/data/operations/storage.operations <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/trunk/KDE/kdelibs/plasma/datacontainer.h <span style="color: grey">(1147556)</span></li>

 <li>/trunk/KDE/kdelibs/plasma/datacontainer.cpp <span style="color: grey">(1147556)</span></li>

 <li>/trunk/KDE/kdelibs/plasma/dataengine.h <span style="color: grey">(1147556)</span></li>

 <li>/trunk/KDE/kdelibs/plasma/dataengine.cpp <span style="color: grey">(1147556)</span></li>

 <li>/trunk/KDE/kdelibs/plasma/private/datacontainer_p.h <span style="color: grey">(1147556)</span></li>

 <li>/trunk/KDE/kdelibs/plasma/private/dataengine_p.h <span style="color: grey">(1147556)</span></li>

 <li>/trunk/KDE/kdelibs/plasma/private/storage_p.h <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4548/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>