<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4537/">http://reviewboard.kde.org/r/4537/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 7th, 2010, 8:10 p.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>i don't think i'm in favor or such a change.
the tabbar was designed to be something really simple, never to really work as complex stuff like a browser tabbar.
moreover, it's already possible to enable close buttons on the tabs, as well i think putting a qwidget at the top left corner of the tabbar.
redoing this from scratch gives also problems like not respecting the layout direction and support different paradigms like where put the new or the close buttons. </pre>
</blockquote>
<p>On July 8th, 2010, 10:39 a.m., <b>Giulio Camuffo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>i didn't add a showNewTabButton() and a showCloseTabButton() method but a setCornerWidget. While it is true that what i want to do is to add those buttons this is a generic method that can be used to add whenever qgw you want, so the layout direction hasn't to be managed by the TabBar, but by who adds the buttons.
Unfortunately (Q,K)TabBar don't have any method allowing that, and while putting a button outside the TabBar works, it isn't graphically nice. When the TabBar does the SlideAnimation it sets ItemClipsChildrenToShape so the widgets are cut under the button, while by a user pov the space under the button is of the TabBar.</pre>
</blockquote>
</blockquote>
<pre>ok, let's go for this corner wdget patch, keeping as general as possible.
api wise there are still 2 things i'm not really convinced:
what happens if you add something in the bottomleft corner?
and should the order be swapped when the application layout is rtl?
i think thisshould become a setFirstPositionWidget() and setLastPositionWidget()
so no invalid corners and would have to be inverted in rtl languages</pre>
<br />
<p>- Marco</p>
<br />
<p>On July 7th, 2010, 5:17 p.m., Giulio Camuffo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Giulio Camuffo.</div>
<p style="color: grey;"><i>Updated 2010-07-07 17:17:22</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">This patch adds two methods that allow to put two QGraphicsWidget in the top left and top right corner of the tab bar, like it is possible with QTabWidget.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Tested, it works, but there's one thing that annoys me and I don't how to solve in a clean way: when there are no tabs the NativeTabBar becomes a bit smaller in height and the widgets resize accordingly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/plasma/widgets/tabbar.h <span style="color: grey">(1147219)</span></li>
<li>trunk/KDE/kdelibs/plasma/widgets/tabbar.cpp <span style="color: grey">(1147219)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4537/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://reviewboard.kde.org/r/4537/s/446/"><img src="http://reviewboard.kde.org/media/uploaded/images/2010/07/07/tabbar_400x100.png" style="border: 1px black solid;" alt="added two Plasma::PushButton" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>