<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4519/">http://reviewboard.kde.org/r/4519/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 8th, 2010, 8:31 a.m., <b>Beat Wolf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>Looks good to me, and trunk is open again.</pre>
</blockquote>
<p>On July 8th, 2010, 9:52 a.m., <b>Iamluc</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>Thanks you for the review.
I don't have an SVN account yet (and I think it's too early to ask one). So could you please commit the patch for me ?</pre>
</blockquote>
<p>On July 8th, 2010, 10:28 a.m., <b>Simon Stiphanos</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>Hello IamLuc and Beat Wolf,
I reported the original bug and would like to point out how to better fix it than this patch currently does. The "Plasma::Label" is extremely large for what is being reported. It should be much smaller to encase just enough for the text because there is no reason to waste such a large amount of real estate.
Do you agree?</pre>
</blockquote>
<p>On July 8th, 2010, 10:51 a.m., <b>Beat Wolf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>i wait for now with commiting</pre>
</blockquote>
<p>On July 8th, 2010, 12:38 p.m., <b>Iamluc</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>Hi Simon,
Maybe the popup is too big for an empty folder, but we need "empty space" in case we want to create a new file (ie, right-click > new) or paste files/folders.
For the moment, all the popups have the same size. More generally than for an empty folder, I think what you want is to automatically resize the popup according to its content (If there is only 1 file, the popup must be smaller than if there are 10 files).
Am I correct ? If yes, I think we need advices/comments about this behaviour with more "experimented" plasma developpers (It's only my first patch !)
(Sorry for my poor english, I hope you will understand :-/)
</pre>
</blockquote>
</blockquote>
<pre>Thanks for the reply IamLuc, but that's not exactly what I mean. Is it at all possible to resize just this element? (And your English is still very readable :)</pre>
<br />
<p>- Simon</p>
<br />
<p>On July 3rd, 2010, 5:11 p.m., Iamluc wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Iamluc.</div>
<p style="color: grey;"><i>Updated 2010-07-03 17:11:02</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Hello,
This patch add a Plasma::Label with text "This folder is empty." in Folderview's Popup when the folder is empty.
The related bug number in kde bugzilla is 201542.
Luc</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Delete/add files several times. The label disappears/appears correctly.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=201542">201542</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h <span style="color: grey">(1145373)</span></li>
<li>/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp <span style="color: grey">(1145373)</span></li>
<li>/trunk/KDE/kdebase/apps/plasma/applets/folderview/popupview.h <span style="color: grey">(1145373)</span></li>
<li>/trunk/KDE/kdebase/apps/plasma/applets/folderview/popupview.cpp <span style="color: grey">(1145373)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4519/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://reviewboard.kde.org/r/4519/s/444/"><img src="http://reviewboard.kde.org/media/uploaded/images/2010/07/03/folderview_400x100.png" style="border: 1px black solid;" alt="folderview empty folder" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>