<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4440/">http://reviewboard.kde.org/r/4440/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 22nd, 2010, 12:16 p.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>even if it can be seen as a feature it's pretty important that goes in asap, before 4.5
btw, looking at the patch they shouldn't, but did you see if doesn't interfere with identica?</pre>
</blockquote>
</blockquote>
<pre>I look at it as more of a bugfix than a feature. Tested it and it doesn't interfere with identica</pre>
<br />
<p>- Ryan</p>
<br />
<p>On June 22nd, 2010, 11:47 a.m., Ryan Bitanga wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Ryan Bitanga.</div>
<p style="color: grey;"><i>Updated 2010-06-22 11:47:11</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">This patch adds oauth support for the microblog dataengine when used with twitter. No changes need to be made to the applet.
Helper functions for signature generation and conversion of http request parameters to strings were based on qoauth by Dominik Kapusta.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=242048">242048</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeplasma-addons/dataengines/microblog/CMakeLists.txt <span style="color: grey">(1141257)</span></li>
<li>/trunk/KDE/kdeplasma-addons/dataengines/microblog/oauth.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeplasma-addons/dataengines/microblog/oauth.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeplasma-addons/dataengines/microblog/timelinesource.h <span style="color: grey">(1141257)</span></li>
<li>/trunk/KDE/kdeplasma-addons/dataengines/microblog/timelinesource.cpp <span style="color: grey">(1141257)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4440/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>