<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4418/">http://reviewboard.kde.org/r/4418/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre>i quite like the improved look, there is one change that needs to be made noted below, but then it can go in.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/4418/diff/1/?file=29536#file29536line433" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;">void Clock::paintInterface(QPainter *p, const QStyleOptionGraphicsItem *option, const QRect &rect)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">433</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"> <span class="k">return</span> <span class="n">QRect</span><span class="p">((</span><span class="n">rect</span><span class="p">.</span><span class="n">width</span><span class="p">()</span> <span class="o">-</span> <span class="n">width</span><span class="p">)</span> <span class="o">/</span> <span class="mi">2</span><span class="p">,</span> <span class="n">rect</span><span class="p">.</span><span class="n">bottom</span><span class="p">()</span> <span class="o">-</span> <span class="n">height</span><span class="p">,</span> <span class="n">width</span><span class="p">,</span> <span class="n">height</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em">in the case of a small analog clock with a long city name, this will result in returning a rect that is wider than the widget.
so width needs to be bounded to rect.width(). </pre>
</div>
<br />
<p>- Aaron</p>
<br />
<p>On June 21st, 2010, 5:16 a.m., Alain Boyer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Alain Boyer.</div>
<p style="color: grey;"><i>Updated 2010-06-21 05:16:47</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">This patch adjusts the timezone label of the analog clock to the width of the city text. Although this is a cosmetic change that is very subjective, I find that the overall look, when multiple clocks are horizontally aligned next to each other, is nicer and more polished.
This is a very minor change, but since I have been away from KDE hacking for a while and we are so close to the next release, I figured I'd put it up for review.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Works just fine in plasmoidviewer.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.h <span style="color: grey">(1140389)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp <span style="color: grey">(1140389)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4418/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://reviewboard.kde.org/r/4418/s/440/"><img src="http://reviewboard.kde.org/media/uploaded/images/2010/06/21/clock_before__400x100.png" style="border: 1px black solid;" alt="Before" /></a>
<a href="http://reviewboard.kde.org/r/4418/s/441/"><img src="http://reviewboard.kde.org/media/uploaded/images/2010/06/21/clock_after__400x100.png" style="border: 1px black solid;" alt="After" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>