Seems fine to me. I think the reason we used unix specific libraries originally was we did not plan on supporting plasma on other OSs. Clearly that's no longer the case so this makes sense.<br><br><div class="gmail_quote">
On Sun, Jun 6, 2010 at 2:08 PM, Alessandro Diaferia <span dir="ltr"><<a href="mailto:alediaferia@gmail.com">alediaferia@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im"><br>
-----------------------------------------------------------<br>
This is an automatically generated e-mail. To reply, visit:<br>
</div><a href="http://reviewboard.kde.org/r/4241/#review6000" target="_blank">http://reviewboard.kde.org/r/4241/#review6000</a><br>
-----------------------------------------------------------<br>
<br>
Ship it!<br>
<br>
<br>
Can't imagine anything saner than this. Of course last word to Christopher.<br>
<br>
- Alessandro<br>
<div class="im"><br>
<br>
On 2010-06-06 13:15:14, Pino Toscano wrote:<br>
><br>
> -----------------------------------------------------------<br>
> This is an automatically generated e-mail. To reply, visit:<br>
> <a href="http://reviewboard.kde.org/r/4241/" target="_blank">http://reviewboard.kde.org/r/4241/</a><br>
> -----------------------------------------------------------<br>
><br>
</div>> (Updated 2010-06-06 13:15:14)<br>
<div><div></div><div class="h5">><br>
><br>
> Review request for Plasma and Christopher Blauvelt.<br>
><br>
><br>
> Summary<br>
> -------<br>
><br>
> Currently, the soliddevice data engine use either statvfs() or statfs() for determine the free space on a mount point.<br>
> This, other than requiring per-OS code which does not cover all the OS KDE supports (for example Windows), is already wrapped in a nice API in kio, the class KDiskFreeSpaceInfo.<br>
><br>
> The proposed patch applies this class to the soliddevice data engine, although making it depend on kio.<br>
><br>
><br>
> Diffs<br>
> -----<br>
><br>
> /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/soliddevice/CMakeLists.txt 1135061<br>
> /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/soliddevice/soliddeviceengine.cpp 1135061<br>
><br>
> Diff: <a href="http://reviewboard.kde.org/r/4241/diff" target="_blank">http://reviewboard.kde.org/r/4241/diff</a><br>
><br>
><br>
> Testing<br>
> -------<br>
><br>
> Looks reporting the correct value for mounted mount points, when queried via plasmaengineexplorer.<br>
><br>
><br>
> Thanks,<br>
><br>
> Pino<br>
><br>
><br>
<br>
</div></div></blockquote></div><br>