<br><br><div class="gmail_quote">2010/5/4 Christophe Olinger <span dir="ltr"><<a href="mailto:olingerc@binarylooks.com">olingerc@binarylooks.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
<br>
> On 2010-05-03 14:36:29, Alessandro Diaferia wrote:<br>
> ><br>
<br>
Applied all the suggestions. Thanks for the QFlags idea.<br>
For the next patch I'll review all my functions and variables for "const" and "virtual" and pure virtual. It'll also include all the stuff that I showed in my blog post.<br>
<font color="#888888"><br>
<br>
- Christophe<br>
</font><div class="im"><br>
<br>
-----------------------------------------------------------<br>
This is an automatically generated e-mail. To reply, visit:<br>
<a href="http://reviewboard.kde.org/r/3552/#review5322" target="_blank">http://reviewboard.kde.org/r/3552/#review5322</a><br>
-----------------------------------------------------------<br>
<br>
<br>
</div><div><div></div><div class="h5">On 2010-04-27 16:44:10, Christophe Olinger wrote:<br>
><br>
> -----------------------------------------------------------<br>
> This is an automatically generated e-mail. To reply, visit:<br>
> <a href="http://reviewboard.kde.org/r/3552/" target="_blank">http://reviewboard.kde.org/r/3552/</a><br>
> -----------------------------------------------------------<br>
><br>
> (Updated 2010-04-27 16:44:10)<br>
><br>
><br>
> Review request for Plasma and Alessandro Diaferia.<br>
><br>
><br>
> Summary<br>
> -------<br>
><br>
> The state calsses now have less functions. Only one for connections and one for configuration. The first one is only called once at PMC initialization, the second one is called at each state switch. Some connections can conflict between states. Those are connected at entry() and disconnected at exit(). Thanks to Alessandr's work we can now also configure the layout from within the state class (I only had to correct some namespace stuff in the medialayout class, I hope that was correct).<br>
> This patch also gets basic functionality back. The modes are not really useful yet. Video mode is the most complete and can be used to view everything at th moment.<br>
> Next step: Clean this up a bit<br>
> Think about subclassing plasma widgets to get the widget type into the widget. This is necessary to be able to tell the controller to layout into zones.<br>
> Start work on information bar.<br>
><br>
><br>
> Diffs<br>
> -----<br>
><br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/CMakeLists.txt 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/abstractmediaitemview.h 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/abstractmediaitemview.cpp 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/mediabrowser.h 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/mediabrowser.cpp 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/mediabrowserlibs/modelpackage.h 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/CMakeLists.txt 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localfiles/CMakeLists.txt 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localfiles/localconfig.ui 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localfiles/localfiles.desktop 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localfiles/localfilespackage.h 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localfiles/localfilespackage.cpp 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localmusic/CMakeLists.txt PRE-CREATION<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localmusic/localmusic.desktop PRE-CREATION<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localmusic/localmusicconfig.ui PRE-CREATION<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localmusic/localmusicpackage.h PRE-CREATION<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localmusic/localmusicpackage.cpp PRE-CREATION<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localpictures/CMakeLists.txt PRE-CREATION<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localpictures/localpictures.desktop PRE-CREATION<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localpictures/localpicturesconfig.ui PRE-CREATION<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localpictures/localpicturespackage.h PRE-CREATION<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localpictures/localpicturespackage.cpp PRE-CREATION<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localvideos/CMakeLists.txt PRE-CREATION<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localvideos/localvideos.desktop PRE-CREATION<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localvideos/localvideosconfig.ui PRE-CREATION<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localvideos/localvideospackage.h PRE-CREATION<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/modelpackages/localvideos/localvideospackage.cpp PRE-CREATION<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/viewitem.h 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/viewitem.cpp 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediacontroller/controller.h 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediacontroller/controller.cpp 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediainfobar/CMakeLists.txt PRE-CREATION<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediainfobar/mediainfobar.h PRE-CREATION<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediainfobar/mediainfobar.cpp PRE-CREATION<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediainfobar/plasma-applet-mediainfobar.desktop PRE-CREATION<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediaplayer/config.ui 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediaplayer/mediaplayer.h 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediaplayer/mediaplayer.cpp 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/playlist/playlistapplet.h 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/playlist/playlistapplet.cpp 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/playlist/playlistwidget.h 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/applets/playlist/playlistwidget.cpp 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/mediacontainment.h 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/mediacontainment.cpp 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/CMakeLists.txt 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/browser.h 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/browser.cpp 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/homestate.h PRE-CREATION<br>
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/homestate.cpp PRE-CREATION<br>
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/infodisplay.h PRE-CREATION<br>
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/infodisplay.cpp PRE-CREATION<br>
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenter.h 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenterstate.h 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenterstate.cpp 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/medialayout.h 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/medialayout.cpp 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/musicstate.h 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/musicstate.cpp 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/picturestate.h 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/picturestate.cpp 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/playbackcontrol.h 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/playbackcontrol.cpp 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/player.h 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/player.cpp 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/playlist.h 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/videostate.h 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/videostate.cpp 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/shells/plasmediacenter/mainwindow.h 1117494<br>
> trunk/playground/base/plasma/MediaCenterComponents/shells/plasmediacenter/mainwindow.cpp 1117494<br>
><br>
> Diff: <a href="http://reviewboard.kde.org/r/3552/diff" target="_blank">http://reviewboard.kde.org/r/3552/diff</a><br>
><br>
><br>
> Testing<br>
> -------<br>
><br>
> Lots and lots. Seems to be quite slow, but I think that is a problem in the player. It always iterates over all the queue even if it should only show a picture.<br>
><br>
><br>
> Thanks,<br>
><br>
> Christophe<br>
><br>
><br>
<br>
</div></div></blockquote></div><br>What's the state of this patch? I'd like you to apply this as soon as it is in an acceptable state and then start sending more specific patches. With this i mean you should start sending different patches for the applets, dataengines, library, backends, etc sub-fields. This way other devs can work on PMC with a lower risk of breaking what you are working on. I say this also to help Hayri, the GSoC student, to start hacking directly on PMC.<br clear="all">
<br><div>Cheers<br>-- <br>Alessandro Diaferia<br>KDE Developer<br>KDE e.V. member<br><br>
</div>