<br><br><div class="gmail_quote">2009/8/22 Giulio Camuffo <span dir="ltr"><<a href="mailto:giuliocamuffo@gmail.com">giuliocamuffo@gmail.com</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
> 2009/8/21 Alessandro Diaferia <alediaferia at <a href="http://gmail.com" target="_blank">gmail.com</a>><br>
><br>
> > 2009/8/21 Giulio Camuffo <giuliocamuffo at <a href="http://gmail.com" target="_blank">gmail.com</a>><br>
<div class="im">> ><br>
> >> > On 2009-08-21 17:23:18, Alessandro Diaferia wrote:<br>
> >><br>
</div>> >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifie<br>
<div class="im">> >>r.h, line 106<br>
> >><br>
> >> > > <<br>
> >><br>
> >> <a href="http://reviewboard.kde.org/r/1370/diff/3/?file=10433#file10433line106" target="_blank">http://reviewboard.kde.org/r/1370/diff/3/?file=10433#file10433line106</a>><br>
> >><br>
> >> > > consider deleting white spaces<br>
> >><br>
> >> eh, the problem with white spaces is that they are... white :p they<br>
> >> escape!<br>
> ><br>
> > That's why reviewboard shows them :p<br>
> ><br>
> >> > On 2009-08-21 17:23:18, Alessandro Diaferia wrote:<br>
> >><br>
</div>> >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifie<br>
<div class="im">> >>r.cpp, line 335<br>
> >><br>
> >> > > <<br>
> >><br>
> >> <a href="http://reviewboard.kde.org/r/1370/diff/3/?file=10434#file10434line335" target="_blank">http://reviewboard.kde.org/r/1370/diff/3/?file=10434#file10434line335</a>><br>
> >><br>
> >> > > No need for this anymore: i've committed a fixed for the bug and<br>
> >><br>
> >> closed it.<br>
> >><br>
> >> whooo! great! thanks<br>
> ><br>
> > =) no problem<br>
> ><br>
> >> - Giulio<br>
> >><br>
> >><br>
> >> -----------------------------------------------------------<br>
</div><div class="im">> >> This is an automatically generated e-mail. To reply, visit:<br>
</div><div class="im">> >> <a href="http://reviewboard.kde.org/r/1370/#review2112" target="_blank">http://reviewboard.kde.org/r/1370/#review2112</a><br>
> >> -----------------------------------------------------------<br>
> >><br>
> >> On 2009-08-21 14:05:09, Giulio Camuffo wrote:<br>
> >> > -----------------------------------------------------------<br>
</div><div class="im">> >> > This is an automatically generated e-mail. To reply, visit:<br>
> >> > <a href="http://reviewboard.kde.org/r/1370/" target="_blank">http://reviewboard.kde.org/r/1370/</a><br>
> >> > -----------------------------------------------------------<br>
> >> ><br>
</div><div class="im">> >> > (Updated 2009-08-21 14:05:09)<br>
> >> ><br>
> >> ><br>
> >> > Review request for Plasma.<br>
> >> ><br>
> >> ><br>
</div><div class="im">> >> > Summary<br>
> >> > -------<br>
> >> ><br>
> >> > This is a patch that modifies quite heavily the behaviour of the<br>
> >> > Device<br>
> >><br>
> >> Notifier.<br>
> >><br>
> >> > It comes from here:<br>
> >><br>
> >> <a href="http://kde-look.org/content/show.php/Device+Manager?content=106051" target="_blank">http://kde-look.org/content/show.php/Device+Manager?content=106051</a><br>
> >><br>
> >> > It can show the not removable devices too, it can mount them<br>
> >><br>
> >> automatically or with a click, since the "eject" button is a "mount"<br>
> >> button when the volume is umounted. So that guy on the dot will be ok.<br>
> >><br>
> >> > It can hide some items in the same way as Dolphin's places (hide item/<br>
> >><br>
> >> show all).<br>
> >><br>
> >> > Finally, it shows the various opening actions under the device instead<br>
> >><br>
> >> of calling that xp-ish window.<br>
> >><br>
> >> > Diffs<br>
</div>> >> > -----<br>
<div class="im">> >><br>
> >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.tx<br>
</div>> >>t 1013960<br>
> >><br>
> >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configuration<br>
> >>page.ui PRE-CREATION<br>
> >><br>
> >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifie<br>
<div class="im">> >>r.h 1013960<br>
> >><br>
> >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifie<br>
> >>r.cpp 1013960<br>
> >><br>
> >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespacein<br>
> >>fodelegate.h 1013960<br>
> >><br>
</div>> >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespacein<br>
> >>fodelegate.cpp 1013960<br>
> >><br>
> >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialo<br>
> >>g.h 1013960<br>
> >><br>
> >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialo<br>
<div class="im">> >>g.cpp 1013960<br>
> >><br>
> >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.<br>
> >>h 1013960<br>
> >><br>
> >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.<br>
> >>cpp 1013960<br>
> >><br>
> >> > Diff: <a href="http://reviewboard.kde.org/r/1370/diff" target="_blank">http://reviewboard.kde.org/r/1370/diff</a><br>
> >> ><br>
> >> ><br>
> >> > Testing<br>
> >> > -------<br>
> >> ><br>
> >> > I'm using it every day since I released 0.1 on Kde-look. I tried all<br>
> >> > the<br>
> >><br>
> >> options on my pc and they work. Some people on kde-look posted some<br>
> >> comments about some problems, but it seems to me they are very<br>
> >> particular cases, so in my opinion it is quite stable to go in trunk,<br>
> >> but anyway review it! :)<br>
> >><br>
> >> > Screenshots<br>
> >> > -----------<br>
> >> ><br>
> >> > screen<br>
> >> > <a href="http://reviewboard.kde.org/r/1370/s/183/" target="_blank">http://reviewboard.kde.org/r/1370/s/183/</a><br>
> >> ><br>
> >> ><br>
> >> > Thanks,<br>
> >> ><br>
> >> > Giulio<br>
> ><br>
</div>> > --<br>
<div class="im">> > Alessandro Diaferia<br>
> > KDE Developer<br>
><br>
> Oh one last thing that comes to my mind is that the configuration dialog<br>
> does not follow GUI usability guidelines. But that shouldn't be a problem,<br>
> there can be a patch for it later :)<br>
><br>
> --<br>
> Alessandro Diaferia<br>
> KDE Developer<br>
<br>
</div>Yes, I know that I'm not good at all at drawing interfaces, and I don't like<br>
very much the designer. I prefer very much to work underground :)<br>
Anyway, since I don't have an svn account, if you judge the patch ready, feel<br>
free to commit it.<br>
<div><div></div><div class="h5">_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br>
</div></div></blockquote></div><br>I've tested the patch and it works correctly. I'd clean indentation a little before committing. Just waiting until sunday before committing so, if someone is against the patch, speak now or shut up forever =)<br clear="all">
<br>-- <br>Alessandro Diaferia<br>KDE Developer<br>