<br><br><div class="gmail_quote">2009/8/21 Alessandro Diaferia <span dir="ltr"><<a href="mailto:alediaferia@gmail.com">alediaferia@gmail.com</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br><br><div class="gmail_quote">2009/8/21 Giulio Camuffo <span dir="ltr"><<a href="mailto:giuliocamuffo@gmail.com" target="_blank">giuliocamuffo@gmail.com</a>></span><div class="im"><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
> On 2009-08-21 17:23:18, Alessandro Diaferia wrote:<br>
> > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h, line 106<br>
> > <<a href="http://reviewboard.kde.org/r/1370/diff/3/?file=10433#file10433line106" target="_blank">http://reviewboard.kde.org/r/1370/diff/3/?file=10433#file10433line106</a>><br>
> ><br>
> > consider deleting white spaces<br>
> ><br>
<br>
eh, the problem with white spaces is that they are... white :p they escape!</blockquote></div><div>That's why reviewboard shows them :p <br></div><div class="im"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
<br>
> On 2009-08-21 17:23:18, Alessandro Diaferia wrote:<br>
> > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp, line 335<br>
> > <<a href="http://reviewboard.kde.org/r/1370/diff/3/?file=10434#file10434line335" target="_blank">http://reviewboard.kde.org/r/1370/diff/3/?file=10434#file10434line335</a>><br>
<div>> ><br>
> > No need for this anymore: i've committed a fixed for the bug and closed it.<br>
<br>
</div>whooo! great! thanks</blockquote></div><div>=) no problem<br> <br></div><div><div></div><div class="h5"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<font color="#888888"><br>
<br>
- Giulio<br>
</font><div><br>
<br>
-----------------------------------------------------------<br>
This is an automatically generated e-mail. To reply, visit:<br>
<a href="http://reviewboard.kde.org/r/1370/#review2112" target="_blank">http://reviewboard.kde.org/r/1370/#review2112</a><br>
-----------------------------------------------------------<br>
<br>
<br>
</div><div><div></div><div>On 2009-08-21 14:05:09, Giulio Camuffo wrote:<br>
><br>
> -----------------------------------------------------------<br>
> This is an automatically generated e-mail. To reply, visit:<br>
> <a href="http://reviewboard.kde.org/r/1370/" target="_blank">http://reviewboard.kde.org/r/1370/</a><br>
> -----------------------------------------------------------<br>
><br>
> (Updated 2009-08-21 14:05:09)<br>
><br>
><br>
> Review request for Plasma.<br>
><br>
><br>
> Summary<br>
> -------<br>
><br>
> This is a patch that modifies quite heavily the behaviour of the Device Notifier.<br>
> It comes from here: <a href="http://kde-look.org/content/show.php/Device+Manager?content=106051" target="_blank">http://kde-look.org/content/show.php/Device+Manager?content=106051</a><br>
> It can show the not removable devices too, it can mount them automatically or with a click, since the "eject" button is a "mount" button when the volume is umounted. So that guy on the dot will be ok.<br>
> It can hide some items in the same way as Dolphin's places (hide item/ show all).<br>
> Finally, it shows the various opening actions under the device instead of calling that xp-ish window.<br>
><br>
><br>
> Diffs<br>
> -----<br>
><br>
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt 1013960<br>
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui PRE-CREATION<br>
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h 1013960<br>
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp 1013960<br>
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h 1013960<br>
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp 1013960<br>
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h 1013960<br>
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp 1013960<br>
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h 1013960<br>
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp 1013960<br>
><br>
> Diff: <a href="http://reviewboard.kde.org/r/1370/diff" target="_blank">http://reviewboard.kde.org/r/1370/diff</a><br>
><br>
><br>
> Testing<br>
> -------<br>
><br>
> I'm using it every day since I released 0.1 on Kde-look. I tried all the options on my pc and they work. Some people on kde-look posted some comments about some problems, but it seems to me they are very particular cases, so in my opinion it is quite stable to go in trunk, but anyway review it! :)<br>
><br>
><br>
> Screenshots<br>
> -----------<br>
><br>
> screen<br>
> <a href="http://reviewboard.kde.org/r/1370/s/183/" target="_blank">http://reviewboard.kde.org/r/1370/s/183/</a><br>
><br>
><br>
> Thanks,<br>
><br>
> Giulio<br>
><br>
><br>
<br>
</div></div></blockquote></div></div></div><font color="#888888"><br><br clear="all"><br>-- <br>Alessandro Diaferia<br>KDE Developer<br>
</font></blockquote></div><br><br clear="all">Oh one last thing that comes to my mind is that the configuration dialog does not follow GUI usability guidelines. But that shouldn't be a problem, there can be a patch for it later :)<br>
<br>-- <br>Alessandro Diaferia<br>KDE Developer<br>