<br><br><div class="gmail_quote">2009/8/17 Sebastian Kügler <span dir="ltr"><<a href="mailto:sebas@kde.org">sebas@kde.org</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im"><br>
-----------------------------------------------------------<br>
This is an automatically generated e-mail. To reply, visit:<br>
</div><a href="http://reviewboard.kde.org/r/632/#review2065" target="_blank">http://reviewboard.kde.org/r/632/#review2065</a><br>
-----------------------------------------------------------<br>
<br>
<br>
I've tested the patch on current trunk, about to commit it, but I don't see any progress bar showing up. The patch probably needs updating.<br>
<br>
- Sebastian<br>
<div class="im"><br>
<br>
On 2009-05-12 14:28:58, mck182 wrote:<br>
><br>
> -----------------------------------------------------------<br>
> This is an automatically generated e-mail. To reply, visit:<br>
> <a href="http://reviewboard.kde.org/r/632/" target="_blank">http://reviewboard.kde.org/r/632/</a><br>
> -----------------------------------------------------------<br>
><br>
</div>> (Updated 2009-05-12 14:28:58)<br>
><br>
><br>
> Review request for Plasma.<br>
<div class="im">><br>
><br>
> Summary<br>
> -------<br>
><br>
> This patch adds a KCapacityBar into the device notifier plasmoid to show the device's free space.<br>
><br>
><br>
> Diffs<br>
</div><div class="im">> -----<br>
><br>
> trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt 965209<br>
> trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp 965209<br>
> trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h PRE-CREATION<br>
> trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp PRE-CREATION<br>
> trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h 965209<br>
> trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp 965209<br>
> trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp 965209<br>
><br>
> Diff: <a href="http://reviewboard.kde.org/r/632/diff" target="_blank">http://reviewboard.kde.org/r/632/diff</a><br>
><br>
><br>
> Testing<br>
> -------<br>
><br>
><br>
> Thanks,<br>
><br>
> mck182<br>
><br>
><br>
<br>
</div><div><div></div><div class="h5">_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br>
</div></div></blockquote></div><br>I've updated the patch and now it correctly shows the capacity bar. There's only a little issue: as soon as the device gets "mounted" the engine does not return a valid "Free Space" data. This is probably a problem with the engine or, worse, with solid.. Will check it out though..<br>
<br><br clear="all"><br>-- <br>Alessandro Diaferia<br>KDE Developer<br>