<br><br><div class="gmail_quote">On Fri, Jun 12, 2009 at 5:29 PM, Aaron J. Seigo <span dir="ltr"><<a href="mailto:aseigo@kde.org">aseigo@kde.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im">On Friday 12 June 2009, Alexis Ménard wrote:<br>
> On Fri, Jun 12, 2009 at 3:40 PM, Akmanalp, Mehmet A<br>
<<a href="mailto:makmanalp@wpi.edu">makmanalp@wpi.edu</a>>wrote:<br>
<br>
</div><div class="im">> > 1) Move the old animator.cpp into deprecated/ and create a whole new<br>
> > animator.cpp with a whole new Plasma::Animator? If so, how is this<br>
> > "extend Plasma::Animator"?<br>
><br>
> Yes move it just. And create a new class for now.<br>
><br>
> > 2) Move the old animator.cpp into deprecated/ and extend it in the new<br>
> > animator.cpp? Then, this doesn't solve the naming issue(We still have<br>
> > to use a different name, not "Animator"), and it isn't "retro-fitting<br>
> > Animation".<br>
><br>
> You can't remove it completly, symbols have to be here for binary<br>
> compatibilty reasons.<br>
> Grab a name (can't be Animator), the one you want, we will see later.<br>
<br>
</div>erf.. i'm concerned we're going to confuse Mehmet with conflicting advice ...<br>
but here goes anyways ;)<br>
<br>
my thoughts are this:<br>
<br>
Animator is a great name and says what it does; i don't want two classes<br>
kicking around, and we can't remove Animator. soooo:<br>
<br>
* mark all the methods currently in Animator as KDE_DEPRECATED<br>
</blockquote><div><br>Didn't know that...<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
* add the new methods for the kinetic project to animator.h<br>
</blockquote><div><br>Yep.<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
* move the current animator.cpp into deprecate<br>
<br>
* create a new .cpp file for the new implementation:<br>
kdelibs/plasma/animator.cpp<br>
<br>
* move the constructor and destructor from plasma/deprecated/animator.cpp into<br>
the new plasma/animator.cpp, as it needs to join the new implementation.<br>
<br>
this means that the deprecated implementation is in<br>
plasma/deprecated/animator.cpp, the new stuff is in plasma/animator.cpp and we<br>
keep Animator around as a class that people use for the kinetic stuff.<br>
<br>
Alexis: does that make sense to you as well? :)</blockquote><div><br>Then it makes sense.<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<font color="#888888"><br>
--<br>
Aaron J. Seigo<br>
humru othro a kohnu se<br>
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43<br>
<br>
KDE core developer sponsored by Qt Software<br>
<br>
</font><br>_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br>
<br></blockquote></div><br>