If we have every file-type selected on default for "Show files matching", that will be fine, but I'm not sure if deselecting all file types for "Hide files matching" would work, because if the user enters some filter, say "foo*" even then foo will be displayed, because its not selected in the MIME types (the file will if hidden if it satisfies both the conditions). So, should I make the MIME types enabled by default in both cases, or any better idea?<br>
<br>P.S. I could not leave a comment at reviewboard, because due to some reason, its not showing be logged in on this particular page.<br><br><div class="gmail_quote">On Mon, Mar 9, 2009 at 3:03 AM, Matthias Fuchs <span dir="ltr"><<a href="mailto:mat69@gmx.net">mat69@gmx.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="im"><br>
<br>
> On 2009-03-08 12:29:21, Chani wrote:<br>
> > the patch itself looks fine, but... isn't there a way we can make the UI better so that there's no need for a tooltip at all?<br>
<br>
</div>One way to avoid unwanted behavior without changing the ui would be to have every file-type selected on default for "Show files matching" and having none selected for "Hide files matching".<br>
<br>
Imo that way it would be more clear how filtering works.<br>
<font color="#888888"><br>
<br>
- Matthias<br>
</font><div class="im"><br>
<br>
-----------------------------------------------------------<br>
This is an automatically generated e-mail. To reply, visit:<br>
<a href="http://reviewboard.kde.org/r/262/#review413" target="_blank">http://reviewboard.kde.org/r/262/#review413</a><br>
-----------------------------------------------------------<br>
<br>
<br>
</div><div><div></div><div class="h5">On 2009-03-08 09:58:46, Shantanu Tushar Jha wrote:<br>
><br>
> -----------------------------------------------------------<br>
> This is an automatically generated e-mail. To reply, visit:<br>
> <a href="http://reviewboard.kde.org/r/262/" target="_blank">http://reviewboard.kde.org/r/262/</a><br>
> -----------------------------------------------------------<br>
><br>
> (Updated 2009-03-08 09:58:46)<br>
><br>
><br>
> Review request for Plasma.<br>
><br>
><br>
> Summary<br>
> -------<br>
><br>
> This changes the UI for the configuration page "Filter" for the applet folderview. As seen in the bug 186283, files are only displayed if they match both the pattern and the MIME type. But there is no obvious indication to this behavior in the interface.<br>
> Added a label "Can't see files?" which has a tooltip explaining the above behavior. (screenshot attached)<br>
> Please review, and if found helpful, commit it, as I don't have a svn account.<br>
><br>
><br>
> This addresses bug 186283.<br>
> <a href="https://bugs.kde.org/show_bug.cgi?id=186283" target="_blank">https://bugs.kde.org/show_bug.cgi?id=186283</a><br>
><br>
><br>
> Diffs<br>
> -----<br>
><br>
> trunk/KDE/kdebase/apps/plasma/applets/folderview/folderviewFilterConfig.ui 936718<br>
><br>
> Diff: <a href="http://reviewboard.kde.org/r/262/diff" target="_blank">http://reviewboard.kde.org/r/262/diff</a><br>
><br>
><br>
> Testing<br>
> -------<br>
><br>
> On latest svn trunk build.<br>
><br>
><br>
> Screenshots<br>
> -----------<br>
><br>
> Filter config page<br>
> <a href="http://reviewboard.kde.org/r/262/s/52/" target="_blank">http://reviewboard.kde.org/r/262/s/52/</a><br>
><br>
><br>
> Thanks,<br>
><br>
> Shantanu<br>
><br>
><br>
<br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Shantanu Tushar<br><a href="http://www.shantanutushar.com">http://www.shantanutushar.com</a><br>