I tried to add check boxes to enable or disable one or both of the Filter and MIME types, but this might unnecessarily complicate the code. Just informing the user should be enough.<br><br><div class="gmail_quote">On Mon, Mar 9, 2009 at 12:59 AM, Chani <span dir="ltr"><<a href="mailto:chanika@gmail.com">chanika@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="im"><br>
-----------------------------------------------------------<br>
This is an automatically generated e-mail. To reply, visit:<br>
</div><a href="http://reviewboard.kde.org/r/262/#review413" target="_blank">http://reviewboard.kde.org/r/262/#review413</a><br>
-----------------------------------------------------------<br>
<br>
<br>
the patch itself looks fine, but... isn't there a way we can make the UI better so that there's no need for a tooltip at all?<br>
<br>
- Chani<br>
<div class="im"><br>
<br>
On 2009-03-08 09:58:46, Shantanu Tushar Jha wrote:<br>
><br>
> -----------------------------------------------------------<br>
> This is an automatically generated e-mail. To reply, visit:<br>
> <a href="http://reviewboard.kde.org/r/262/" target="_blank">http://reviewboard.kde.org/r/262/</a><br>
> -----------------------------------------------------------<br>
><br>
</div>> (Updated 2009-03-08 09:58:46)<br>
<div><div></div><div class="h5">><br>
><br>
> Review request for Plasma.<br>
><br>
><br>
> Summary<br>
> -------<br>
><br>
> This changes the UI for the configuration page "Filter" for the applet folderview. As seen in the bug 186283, files are only displayed if they match both the pattern and the MIME type. But there is no obvious indication to this behavior in the interface.<br>
> Added a label "Can't see files?" which has a tooltip explaining the above behavior. (screenshot attached)<br>
> Please review, and if found helpful, commit it, as I don't have a svn account.<br>
><br>
><br>
> This addresses bug 186283.<br>
> <a href="https://bugs.kde.org/show_bug.cgi?id=186283" target="_blank">https://bugs.kde.org/show_bug.cgi?id=186283</a><br>
><br>
><br>
> Diffs<br>
> -----<br>
><br>
> trunk/KDE/kdebase/apps/plasma/applets/folderview/folderviewFilterConfig.ui 936718<br>
><br>
> Diff: <a href="http://reviewboard.kde.org/r/262/diff" target="_blank">http://reviewboard.kde.org/r/262/diff</a><br>
><br>
><br>
> Testing<br>
> -------<br>
><br>
> On latest svn trunk build.<br>
><br>
><br>
> Screenshots<br>
> -----------<br>
><br>
> Filter config page<br>
> <a href="http://reviewboard.kde.org/r/262/s/52/" target="_blank">http://reviewboard.kde.org/r/262/s/52/</a><br>
><br>
><br>
> Thanks,<br>
><br>
> Shantanu<br>
><br>
><br>
<br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Shantanu Tushar<br><a href="http://www.shantanutushar.com">http://www.shantanutushar.com</a><br>