<br><br><div class="gmail_quote">Am 16. Januar 2009 16:54 schrieb Aaron J. Seigo <span dir="ltr"><<a href="mailto:aseigo@kde.org">aseigo@kde.org</a>></span>:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><div></div><div class="Wj3C7c">On Friday 16 January 2009, Philipp Klaffert wrote:<br>
> Since I had some time I patched some of the minor krazy2 issues in<br>
> kdeplasma-addons. Mostly the QLatin1String and double-quote issues.<br>
> I attached the patch to this mail so feel free to look over it and if its<br>
> Ok, please commit it since I am not able to do so...<br>
<br>
</div></div>i'm really not so much a fan of the QLatin1String changes. in these particular<br>
cases, they don't result in any useful performance improvements and they<br>
aren't technically incorrect, but they do impact readability. the rest of the<br>
changes look ok, however. =)<br>
<font color="#888888"><br>
--<br>
Aaron J. Seigo<br>
humru othro a kohnu se<br>
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43<br>
<br>
KDE core developer sponsored by Qt Software<br>
<br>
</font><br>_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br>
<br></blockquote></div><br><br>After reading your mail and considering that you are absolutely right about that I think I let krazy be crazy about these and focus on other issues.<br><br><br>---<br>Philipp Klaffert<br>