<div dir="ltr"><br><br><div class="gmail_quote">2008/9/11 Aaron J. Seigo <span dir="ltr"><<a href="mailto:aseigo@kde.org">aseigo@kde.org</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="Ih2E3d">On Thursday 11 September 2008, Richard Dale wrote:<br>
</div><div class="Ih2E3d">> Then those wouldn't have any configXml object and this part of the logic<br>
> would never be entered. I'm afraid I still don't see what the early exit<br>
> code is doing.<br>
<br>
</div>that branch is only entered if there isn't a configXml + UI file. at which point<br>
it falls back to asking the ScriptEngine to do the right thing.<br>
<br>
what i do see in that code is that this:<br>
<br>
? ? ? ? if (uiFile.isEmpty()) {<br>
? ? ? ? ? ? return;<br>
? ? ? ? }<br>
<br>
should probably be:<br>
<br>
? ? ? ? if (uiFile.isEmpty()) {<br>
? ? ? ? ? ? if (d->script) {<br>
? ? ? ? ? ? ? ? d->script->showConfigurationInterface();<br>
? ? ? ? ? ? }<br>
<br>
? ? ? ? ? ? return;<br>
? ? ? ? }<br>
<br>
otherwise, i'm really not understanding the issue here. could you be more<br>
verbose (aka "explain it for the stupid people")? =)</blockquote>My apologies, I misread the code. I thought it was testing for a script engine if it had successfully opened the .ui file, which meant it would screw up the automatic display of the dialog. In fact it is only testing for the scripting engine if it has failed to open the .ui file, which shouldn't normally happen anyway. Damn, this has been bugging me for no reason every since I first saw (and misread it). <br>
<br>Anyhow if a .ui file has somehow gone missing when it was originally found in the package, it is just as bad for a scripting applet as for a c++ one. But that is very minor compared with the problem I thought we had, but actually don't..<br>
<br>-- Richard<br></div><br></div>