Monday meeting notes for 28/8/2023

Mon Aug 28 16:11:44 BST 2023

Nico
* I did a bit of refactoring in powerdevil
* Splitting the monolithic "backend" thing into separate classes
* Splitting the monolithic "backend" thing into separate classes
* Based on Arjen's work on ecm_add_qml_module I ported Kirigami to use
declatative type registration
* https://invent.kde.org/frameworks/kirigami/-/merge_requests/1220
* (ecm_add_qml_module not landed yet)
* Proposal for new API for KService::property():
https://invent.kde.org/frameworks/kservice/-/merge_requests/155
* unbroke kwallet after recent change:
https://invent.kde.org/frameworks/kwallet/-/merge_requests/65

Fushan
* Add a message to the deprecation porting guide that strut arguments
must be in device coordinates:
https://invent.kde.org/frameworks/kwindowsystem/-/merge_requests/114.
What do you think of the idea? Most existing users are still using
KWindowSystem::setExtendStruts in KF5, so when they port things they
should notice that.
(https://invent.kde.org/frameworks/kwindowsystem/-/merge_requests/113#note_743400)
* While removing the application dashboard, I also looked into
reviving the rotten code in Kicker, replacing custom drag helper and
the odd Kicker.WindowSystem, using declarative KeyNavigation instead
of forceActiveFocus() to handle keyboard navigation. The code should
be simplified now.

[discussion on dropping the dashboard, current code is not
salvageable, but something is needed for 6.0]
[no objection from me to blow up the current one, kinda feel something
new is eventually needed]

Kai Uwe
KWin:
    Continued on don’t trigger screen edge during implicit pointer grab
    Don’t activate desktop window when it shows up,
https://invent.kde.org/plasma/kwin/-/merge_requests/4349
        imho is a valid real-world fix (and one that X also has), so I
don’t like that debate of principles it sparked again…
Plasma:
    Fixed crash in ContainmentLayoutManager (5.27)
    Fixed excess padding in user switcher applet, please review
cherry-pick: https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/448
(5.27)
    Fixed config button and global shortcut setting not working in
System Tray (6.0)
    Set default message box icon for confirmation prompt in system
settings, please review
https://invent.kde.org/plasma/kwin/-/merge_requests/4349 (6.0)
    Had a look at my constant KRunner crashes, it’s somewhere with
make current in wayland GL context + decorations + threads but can’t
reproduce now that I have a debugger hooked up and some qdebug added…
Apps:
    Fixed Dolphin view icon rendering blurry/pixelated with fractional
scaling (Qt 6)
    Fixed Dolphin text color not updating properly when changing the
color scheme, again… (Qt 6)
    KDialog plays a sound on message boxes now, like “proper” message boxes do
Frameworks:
    Fixed DialogButtonBox sizing, made the QtQuick Dialogs look broken
        They still don’t resize horizontally (can barely fit three
buttons) but that’s a Qt issue
        imho there’s no way around providing our own
MessageDialogHelper based on KMessageDialog in plasma-integration for
Plasma 6
            even if we fixed Qt for 6.7 (which is a big task because
it needs infra to use widgets without pulling that into the main lib…)
that’s still too late for Plasma 6.0
    KMessageDialog uses the correct sound for warning notifications now
    KConfig reads time stamps in UTC now (new Qt 6.6 API), it’s a few
tens of milliseconds faster on startup :-)
        Next up is KService to shed another 0.1ms or so…
Qt:
    Worked on a QGuiApplication::setDefaultTextFormat, so we can force
PlainText everywhere, “fun” discussion:
https://codereview.qt-project.org/c/qt/qtbase/+/498400
    Working on a QScrollBar::createStandardContextMenu, so a caller
can override the context menu without re-implementing it entirely
        Want to add check boxes for toggling minimap on Kate’s scroll bar
    Kickstarted fixing MessagDialog not working without a Window, cf.
https://codereview.qt-project.org/c/qt/qtdeclarative/+/433022
        It’s what broke the “Delete?” confirmation in network settings
    Fixed switching from a shape cursor back to bitmap cursor not
working on Wayland (e.g. kolourpaint tool cursors)
    No longer creates a cursor surface on Wayland at all if only using
shape cursors, tiny optimization :-)
    Wait for compositor to send a fractional scale, don’t assume 1.0 initially
        apps really shhouldn’t be rendering before exposed with the
right scale and output and all, though

[discussion about dialogs, labs version or "proper" which still has problems]

Xaver
* I've been doing a bunch of optimization work for KWin:
* KWin is measuring GPU rendering time properly now, so fewer frames
should get dropped when the GPU can keep up
* for when the GPU doesn't keep up, there's
https://invent.kde.org/plasma/kwin/-/merge_requests/4358 which should
help boost GPU clock speeds when needed. It would be great if someone
with an underpowered Intel laptop could test the MR with the linked
kernel patches
* the cursor should now also stutter less when KWin drops frames, and
I'm working on making it not stutter at all
* there's more stuff pending for making KWin ideally not drop frames
in the first place, but that'll take more time to become reality

Arjen
* main thing is that I've been trying to make sure the
ecm_add_qml_module stuff can be merged, at this point as far as I can
tell things should be fine
* other than that there's some kirigami stuff going on

Meven
* KIO, review
        unit test fix:
        https://invent.kde.org/frameworks/kio/-/merge_requests/1395
        https://invent.kde.org/frameworks/kio/-/merge_requests/1397
        deprecation fixes
        https://invent.kde.org/frameworks/kio/-/merge_requests/1390
* Dolphin review and features (latest one middle to open with second
app associated)
* Plasma, I will revisit,
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3122
* Kwin will test https://invent.kde.org/plasma/kwin/-/merge_requests/4358

DavidR
* I fixed the SDDM theme
* And then I tested the screenlocker and it was still broken, so I
fixed kscreenlocker wallpaper integration too

Marco
* have 5 ready-ish merge requests
* Role stuff in KItemModels, please need this merged
https://invent.kde.org/frameworks/kitemmodels/-/merge_requests/67
* port p-d to KSortFilterProxyModel
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1679
* port remaining QQC1 use
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1680
* port p-w to KSortFilterProxyModel
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3214
* add HeaderITems to qqc style
https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/275

Natalie
* Fixed the powerdevil runner being broken and am in the process of
some more clean-up and enhancements (such as turning screen backlight
off)
* Working on moving brightness handling from the "backend" to a
separate controller class, see
https://invent.kde.org/plasma/powerdevil/-/issues/17
* Once that is done I'm planning to add support for per-monitor
brightness controll, see
https://invent.kde.org/plasma/powerdevil/-/issues/19
* Since then we will have something new in our DBus API, this would be
a good opportunity to port away from data engines in the applet
* Looked into some more backlight related bugs
* Now that upower's main maintainer stepped back, review on
https://gitlab.freedesktop.org/upower/upower/-/merge_requests/203 from
some KDE people would be helpful in moving this forward
* And perhaps split the brightness stuff out into a new applet
straight away, https://invent.kde.org/plasma/plasma-workspace/-/issues/93

Ismail
* Followed up/fixed some small regressions, some port away from
PlasmaCore.SortFilterModel
* And a bit to discuss, gtk developer advised on the sound theme task
against using libcanberra due to being unmantained, an probably
dropped from gtk4
* At the point we're at I think is more of a medium term discussion,
but just to keep tabs on alternatives for the future