D24264: edit mode action and dbus

David Edmundson noreply at phabricator.kde.org
Fri Sep 27 16:14:48 BST 2019


davidedmundson added inline comments.

INLINE COMMENTS

> appletslayout.cpp:100
>          connect(m_window, &QWindow::activeChanged, this, [this]() {
> -            if (!m_window->isActive()) {
> +            if (!qApp->focusWindow()) {
>                  setEditMode(false);

But we only evaluate this when this window changes - doesn't that mean we could when any other plasma window had focus and then loses it?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24264

To: mart, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190927/87c2d973/attachment.html>


More information about the Plasma-devel mailing list