D21963: Keep Klipper notifications out of notification history

Kai Uwe Broulik noreply at phabricator.kde.org
Fri Jun 21 13:43:04 BST 2019


broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This makes Klipper identify as `org.kde.klipper` to the notification service even when running inside of Plasma and installs a rule to disable it from history by default.
  
  BUG: 408989
  FIXED-IN: 5.16.2

TEST PLAN
  Since the desktop file is only shown outside of KDE, it doesn't show in the KCM and as such cannot be changed but I think having its contents not added to history makes sense from a privacy POV.
  
  Maybe we need to introduce a new flag in KNotification, too, or have klipper have a proper notifyrc rather than using generic events or some other solution but this is good enoughâ„¢ for stable.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21963

AFFECTED FILES
  klipper/klipper.cpp
  libnotificationmanager/plasmanotifyrc

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190621/9ed28087/attachment-0001.html>


More information about the Plasma-devel mailing list