D17975: [Notifications] Add padding to notifications

Root noreply at phabricator.kde.org
Thu Jan 10 22:32:57 GMT 2019


rooty added a comment.


  In D17975#391008 <https://phabricator.kde.org/D17975#391008>, @filipf wrote:
  
  > ^ Yes, it's important to note that additional (and unwanted) padding underneath the icon can happen with master, while this patch can add the same above the icon. From my layman's understanding, there is nothing solid and absolute values are based on.
  
  
  There are effectively two problems here:
  
  - How do we get even padding around the **icon itself** without having to resort to manipulating the rest of the notification?
  - How do we get the icon size to increase in proportion to increasing font size (and/or scaling factor) and, once bigger/smaller, how do we get it to stay that very same size regardless of how many lines of text there are?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17975

To: rooty, #vdg, #plasma, ngraham, davidedmundson
Cc: broulik, Codezela, abetts, filipf, davidedmundson, hein, ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190110/ac5ac891/attachment-0001.html>


More information about the Plasma-devel mailing list