D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

Nathaniel Graham noreply at phabricator.kde.org
Thu Feb 28 20:49:46 GMT 2019


ngraham added a comment.


  In D19230#422118 <https://phabricator.kde.org/D19230#422118>, @cfeck wrote:
  
  > Disabling is preferred to hiding. If there is a widget, but not enabled, you are eager to learn how to enable it. If you hide it, you won't even know it exists.
  
  
  Right. My point is that it doesn't really make sense to disable the button when the combobox is something other than "Use Region Defaults". That would just be odd and confusing.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  replace-tristate-checkbox-with-combobox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19230

To: ngraham, #plasma, Zren, #vdg, davidedmundson, ndavis
Cc: cfeck, totte, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190228/72a33d8c/attachment.html>


More information about the Plasma-devel mailing list