D19392: shannon entropy to guess monochrome icon

[David Edmundson]

davidedmundson added a comment.


  > The problem with using -symbolic for all monochrome icons is that we'd have to create color icons without -symbolic to replace the old monochrome icons without -symbolic.
  
  Why would breeze need two versions?
  
  If an app requests -symbolic you get a black icon which we know we can colourise.
  If the app doesn't request -symbolic you get an icon which happens to be all black.
  
  Also it's worth noting there's an FD.O icon spec rule (that will apply for all QIconEngines hopefully) if an app requests  "foo-bar"   and "foo-bar" doesn't exist, it will automatically load "foo"  
  Us requesting "-symbolic" at an app level won't break anything. (though obviously we'll have to port a bunch of app code)
  
  > this tough is about doing something about it in KIconLoader which is completely ortogonal to this patch.
  
  That's absolutely not what this is about, because as you note putting it in KIconLoader wouldn't fix anything at all!
  
  We've got code in Plasma that colours icons. Then we put code in KIconLoader because we didn't account for widgets, now we're putting code here because we didn't account for non-plasma - and we know this is a bodge that's going to get replaced as it doesn't work in a lot of cases.
  If we are running Kirigami on gnome, you probably want to use a gnome icon set at which point this all breaks. I think the app would /need/ to request the "-symbolic" icon?
  
  I'm fully aware I'm being difficult, but I'm doing it because these half solutions keep going on forever and I'm trying to save us some time in the future. 
  If we do want changes in GTK4 and Qt6 we should be thinking about them now.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19392

To: mart, #kirigami
Cc: ngraham, GB_2, ndavis, #vdg, cfeck, davidedmundson, plasma-devel, domson, dkardarakos, apol, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190228/eb226c1d/attachment-0001.html>