D19325: [sddm-theme/lock screen] WIP, Tighten clock shadows

Nathaniel Graham noreply at phabricator.kde.org
Tue Feb 26 16:08:40 GMT 2019


ngraham added a comment.


  Ah, I see now! I even implemented that, touché. :)
  
  Also, why did you change the shadow from a layer effect to a separate item? If that's necessary, it would seem to be appropriate material for another patch since it's not a visual change (unless I'm not noticing it).

INLINE COMMENTS

> Clock.qml:44
> +        samples: 9
> +        spread: 0.25
> +        color: "black" // new Breeze shadow color

If we're emulating the shadows in D16968 <https://phabricator.kde.org/D16968>, shouldn't this be 0.35?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19325

To: rooty, #vdg, ngraham, filipf, mart
Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190226/6c1bcc08/attachment-0001.html>


More information about the Plasma-devel mailing list